From a5bbb9fdbacca3f21ecc43d943bbbf614ef4398b Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 20 Oct 2026 09:37:11 +0000 Subject: [PATCH] open-pr labels a PR with its ticket's category (spike or dev work) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_019r1tYwhEoxpagfCH44etdA --- .../workspace-inherit/.claude/skills/pr-conventions/SKILL.md | 2 +- .../workspace-inherit/.claude/skills/pr-conventions/SKILL.md | 2 +- .../workspace-inherit/.claude/skills/open-pr/SKILL.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/software/application-software/argos/workspace-inherit/.claude/skills/pr-conventions/SKILL.md b/software/application-software/argos/workspace-inherit/.claude/skills/pr-conventions/SKILL.md index 90cc657..2265e4f 100644 --- a/software/application-software/argos/workspace-inherit/.claude/skills/pr-conventions/SKILL.md +++ b/software/application-software/argos/workspace-inherit/.claude/skills/pr-conventions/SKILL.md @@ -10,6 +10,6 @@ The shared rules are in the `open-pr` skill; this adds only what is Argos's. - Base branch: `develop`. Commit format: `^#[0-9]+ - ` (the format in CLAUDE.md). - Checks: `bash scripts/lint.sh ` (frontend prettier and ng lint, only if angular-client/ changed). -- Labels: one written-by (`by: human` if the user wrote it, `by: ai-assisted` if they gave the substance, `by: ai` if you wrote it) and at least one area label (`frontend`, `backend`, `devops`); no category label. +- Labels: one written-by (`by: human` if the user wrote it, `by: ai-assisted` if they gave the substance, `by: ai` if you wrote it) and at least one area label (`frontend`, `backend`, `devops`), besides `open-pr`'s category label. - Screenshots: `pictures//` at the worktree root (git-ignored). - UI QA: get the branch running with `run-local `, then drive it with Playwright, using the `playwright-cdp` server if `curl -s localhost:9222/json/version` responds, otherwise `playwright`. diff --git a/software/application-software/nero/workspace-inherit/.claude/skills/pr-conventions/SKILL.md b/software/application-software/nero/workspace-inherit/.claude/skills/pr-conventions/SKILL.md index 9e2bb17..cff77f5 100644 --- a/software/application-software/nero/workspace-inherit/.claude/skills/pr-conventions/SKILL.md +++ b/software/application-software/nero/workspace-inherit/.claude/skills/pr-conventions/SKILL.md @@ -10,6 +10,6 @@ The shared rules are in the `open-pr` skill; this adds only what is Nero's. - Base branch: `develop`. Commit format: `^#[0-9]+ ` (the format in CLAUDE.md). - Checks: in the worktree, `clang-format --dry-run --Werror` on the C++ files changed since `origin/develop` (not under `deps/`); stop on any error. -- Labels: none. +- Labels: only `open-pr`'s category label. - Screenshots: `playwright/test-results//` in the worktree, never committed. - UI QA, only if QML or a page changed: in the worktree's `playwright/`, add or update a case for each changed page, run `npm test`, and inspect `test-results//` (CLAUDE.md's Playwright section). diff --git a/software/application-software/workspace-inherit/.claude/skills/open-pr/SKILL.md b/software/application-software/workspace-inherit/.claude/skills/open-pr/SKILL.md index b1e7c71..368e6d9 100644 --- a/software/application-software/workspace-inherit/.claude/skills/open-pr/SKILL.md +++ b/software/application-software/workspace-inherit/.claude/skills/open-pr/SKILL.md @@ -7,7 +7,7 @@ First load the project's `pr-conventions` skill (inherited from the project's `w 1. **Check:** `bash scripts/pr-checks.sh origin/ ''` (clean tree, commit subjects match the project's format, merges cleanly into the base), then the project's own checks. Stop and fix on any FAIL. 2. **Media:** if the diff touches the UI, ask the user whether to add screenshots to the PR, listing any already in the project's screenshot folder for this branch so they can pick those instead of new ones; on no, skip this step. For new ones, use the project's UI QA to take Playwright screenshots of the changed views into its screenshot folder, or, when the change adds or changes an animation, record a short video instead (a browser context with `recordVideo: { dir }` saves a `.webm` when it closes). Images must be under 10 MB; video under 10 MB on a Free plan, 100 MB on a paid one. -3. **Open:** push (`git -C worktrees// push -u origin `), then run `(cd worktrees// && gh pr create --draft --base --head --title "" --body-file /tmp/<branch>-pr-body.md --assignee @me)` with the project's labels (`--label`) and one `--attach <file>` per screenshot or video, and report the URL. +3. **Open:** push (`git -C worktrees/<repo>/<branch> push -u origin <branch>`), then run `(cd worktrees/<repo>/<branch> && gh pr create --draft --base <base> --head <branch> --title "<title>" --body-file /tmp/<branch>-pr-body.md --assignee @me)` with the project's labels plus the ticket's category label from `create-ticket`'s Labels (one `--label` each; only spikes and dev work get PRs, never ideas or epics) and one `--attach <file>` per screenshot or video, and report the URL. 4. **Spike:** the PR stays a draft; getting it merged isn't the goal. Once it's checked and working, run `report-spike`. ## PR body