From ce1874c023bb655e05ab9d7bb977aac2250f752a Mon Sep 17 00:00:00 2001 From: PianoNic <79938743+Pianonic@users.noreply.github.com> Date: Tue, 3 Nov 2026 17:01:33 +0100 Subject: [PATCH] Fixed chat_members when Graph throttles the members route It now reads members through chats/{id}?$expand=members, which worked on every chat tested, while chats/{id}/members kept answering 429. --- src/outnote/_teams.py | 5 ++++- tests/test_transport.py | 20 ++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/outnote/_teams.py b/src/outnote/_teams.py index 1b74df9..f31fa79 100644 --- a/src/outnote/_teams.py +++ b/src/outnote/_teams.py @@ -38,7 +38,10 @@ def chat(self, chat_id): return self.get(f"chats/{chat_id}", {"$expand": "members,lastMessagePreview"}) def chat_members(self, chat_id): - return self.list(f"chats/{chat_id}/members") + """The people in a chat, each with `userId` and `displayName`. Reads them through the chat, + because Graph can throttle `chats/{id}/members` heavily (see issue #46).""" + chat = self.get(f"chats/{chat_id}", {"$expand": "members", "$select": "id"}) + return chat.get("members") or [] def unread_chats(self, top=50): """Chats whose last message is newer than when I last read the chat diff --git a/tests/test_transport.py b/tests/test_transport.py index 81953da..2d628dc 100644 --- a/tests/test_transport.py +++ b/tests/test_transport.py @@ -375,3 +375,23 @@ def test_search_is_unchanged(monkeypatch): c = search_client(monkeypatch, ([("1", "x")], True)) assert [r["id"] for r in c.search("w", "chatMessage", 3)] == ["1"] assert c.bodies[0]["size"] == 3 + + +# --- chat_members -------------------------------------------------------------- +def test_chat_members_reads_them_through_the_chat(monkeypatch): + c = outnote.OutNote("tok") + seen = [] + + def get(path, params=None, **k): + seen.append((path, params)) + return {"id": "c", "members": [{"userId": "u1"}, {"userId": "u2"}]} + + monkeypatch.setattr(c, "get", get) + assert [m["userId"] for m in c.chat_members("c")] == ["u1", "u2"] + assert seen == [("chats/c", {"$expand": "members", "$select": "id"})] + + +def test_chat_members_of_a_chat_without_the_field_is_empty(monkeypatch): + c = outnote.OutNote("tok") + monkeypatch.setattr(c, "get", lambda *a, **k: {"id": "c"}) + assert c.chat_members("c") == []