From a1fa1e7717cf9c2e138202b567883412cdf4649b Mon Sep 17 00:00:00 2001 From: Brian O'Kelley Date: Tue, 27 Oct 2026 10:46:01 +0000 Subject: [PATCH] test(release): accept next's storage version in the storage manifest check On next, adcp-reporting-storage releases its own 0.2.0-beta.N line from .release-please-manifest.next.json, but the storage version test only read main's manifest, so the 0.2.0-beta.0 release PR (#1674) failed every Test Python lane. Accept either manifest's storage entry, as the root version test already does. Co-Authored-By: Claude Opus 5.5 (1M context) --- tests/test_release_configuration.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/test_release_configuration.py b/tests/test_release_configuration.py index 95e19f473..99cf52161 100644 --- a/tests/test_release_configuration.py +++ b/tests/test_release_configuration.py @@ -57,9 +57,15 @@ def test_storage_distribution_version_matches_its_manifest_entry() -> None: ) assert project_section is not None manifest = json.loads((ROOT / ".release-please-manifest.json").read_text()) - assert project_section.group(1) == pep440_prerelease( - manifest["packages/adcp-reporting-storage"] - ) + expected = {pep440_prerelease(manifest["packages/adcp-reporting-storage"])} + # On next, the storage package releases its own 0.2.0-beta.N line from + # next's manifest, like the root package does in the test above. + next_manifest = ROOT / ".release-please-manifest.next.json" + if next_manifest.exists(): + next_versions = json.loads(next_manifest.read_text()) + if "packages/adcp-reporting-storage" in next_versions: + expected.add(pep440_prerelease(next_versions["packages/adcp-reporting-storage"])) + assert project_section.group(1) in expected config = json.loads((ROOT / "release-please-config.json").read_text()) package = config["packages"]["packages/adcp-reporting-storage"] assert package["component"] == package["package-name"] == "adcp-reporting-storage"