From 2c47b7c9c2a48747466f760482c0e30a3887e184 Mon Sep 17 00:00:00 2001 From: gspark Date: Fri, 30 Oct 2026 09:59:16 +0900 Subject: [PATCH] pd: index an empty paged KV span as long (#47) PagedKV.physical() built the slot index with torch.as_tensor(slots); for an empty span ([] slots) that is a float32 tensor and table indexing raises IndexError. Pin dtype=torch.long so an empty span_index()/write_span() is a no-op. Adds a CPU regression test. Refs #47 Co-Authored-By: Claude Opus 5.5 --- opt_prime/opt_prime/accel/pd/paged.py | 2 +- opt_prime/tests/test_pd_paged_empty_span.py | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 opt_prime/tests/test_pd_paged_empty_span.py diff --git a/opt_prime/opt_prime/accel/pd/paged.py b/opt_prime/opt_prime/accel/pd/paged.py index 80c235b7..910e8281 100644 --- a/opt_prime/opt_prime/accel/pd/paged.py +++ b/opt_prime/opt_prime/accel/pd/paged.py @@ -415,7 +415,7 @@ def drain_events(self): return out def physical(self, slots, positions): - s = torch.as_tensor(slots, device=self.device) + s = torch.as_tensor(slots, dtype=torch.long, device=self.device) p = torch.as_tensor(positions, device=self.device) return self.table[s, p // self.page_size].long() * self.page_size + p % self.page_size diff --git a/opt_prime/tests/test_pd_paged_empty_span.py b/opt_prime/tests/test_pd_paged_empty_span.py new file mode 100644 index 00000000..79416f8e --- /dev/null +++ b/opt_prime/tests/test_pd_paged_empty_span.py @@ -0,0 +1,21 @@ +"""An empty KV span (nothing left to import, e.g. a fully cached prompt) must index as a no-op (#47).""" +import torch +from opt_prime.accel.pd.paged import PagedKV + + +def pool(): + cache = PagedKV(2, 1, 1, 2, torch.float32, 'cpu', pages=4, page_size=4, max_context=16) + assert cache.alloc(0, 8) == 0 + return cache + + +def test_empty_span_index_is_long_and_empty(): + idx = pool().span_index(0, 5, 5) + assert idx.dtype == torch.long and idx.numel() == 0 + + +def test_empty_span_write_is_noop(): + cache = pool() + empty = torch.ones(2, 1, 0, 2) + cache.write_span(0, 5, empty, empty) + assert all(not x.any() for x in cache.gk + cache.gv)