From 2469788185a6f227f554371ac59dcf51e59c6283 Mon Sep 17 00:00:00 2001
From: ramonskie <ramonmakkelie@gmail.com>
Date: Thu, 22 Oct 2026 12:14:01 +0200
Subject: [PATCH] test: cover redis session store staging

The sessions extension reads php.ini and php-fpm.conf through
NewPHPConfigHelper, which resolves those paths from ctx.BuildDir. BUILD_DIR
is not exported by the lifecycle, and PHP config is written under the
dependency directory, so any app bound to a *-sessions service fails
staging with "extension sessions compile failed: failed to load PHP config".

Add a switchblade integration test that binds a user-provided service named
redis-sessions, asserts staging succeeds, and checks the runtime php.ini
directives the extension rewrites. The fixture reads the ini values without
starting a session, so no Redis server is needed.

Expected to fail until #1313 is merged.
---
 fixtures/with_sessions/index.php     |  5 +++
 src/php/integration/init_test.go     |  1 +
 src/php/integration/sessions_test.go | 62 ++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100644 fixtures/with_sessions/index.php
 create mode 100644 src/php/integration/sessions_test.go

diff --git a/fixtures/with_sessions/index.php b/fixtures/with_sessions/index.php
new file mode 100644
index 000000000..3f5078f78
--- /dev/null
+++ b/fixtures/with_sessions/index.php
@@ -0,0 +1,5 @@
+<?php
+// The sessions extension rewrites these directives in the dependency php.ini
+// during the supply phase. No session is started here, so no Redis server is
+// required for this app to serve.
+echo "handler=" . ini_get("session.save_handler") . "|name=" . ini_get("session.name");
diff --git a/src/php/integration/init_test.go b/src/php/integration/init_test.go
index fcd990d98..bb4500284 100644
--- a/src/php/integration/init_test.go
+++ b/src/php/integration/init_test.go
@@ -81,6 +81,7 @@ func TestIntegration(t *testing.T) {
 	suite("Placeholders", testPlaceholders(platform, fixtures))
 	suite("PreprocessCmds", testPreprocessCmds(platform, fixtures))
 	suite("StandaloneApp", testStandaloneApp(platform, fixtures))
+	suite("Sessions", testSessions(platform, fixtures))
 	// suite("BuildpackPythonExtension", testPythonExtension(platform, fixtures)) // Skipped for now
 	// suite("APMs", testAPMs(platform, fixtures, dynatraceDeployment.InternalURL)) // Needs dynatrace mock
 	if settings.Cached {
diff --git a/src/php/integration/sessions_test.go b/src/php/integration/sessions_test.go
new file mode 100644
index 000000000..58a055bd4
--- /dev/null
+++ b/src/php/integration/sessions_test.go
@@ -0,0 +1,62 @@
+package integration_test
+
+import (
+	"path/filepath"
+	"testing"
+
+	"github.com/cloudfoundry/switchblade"
+	. "github.com/cloudfoundry/switchblade/matchers"
+	. "github.com/onsi/gomega"
+	"github.com/sclevine/spec"
+)
+
+func testSessions(platform switchblade.Platform, fixtures string) func(*testing.T, spec.G, spec.S) {
+	return func(t *testing.T, context spec.G, it spec.S) {
+		var (
+			Expect     = NewWithT(t).Expect
+			Eventually = NewWithT(t).Eventually
+
+			name string
+		)
+
+		it.Before(func() {
+			var err error
+			name, err = switchblade.RandomName()
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		it.After(func() {
+			if t.Failed() && name != "" {
+				t.Logf("❌ FAILED TEST - App/Container: %s", name)
+				t.Logf("   Platform: %s", settings.Platform)
+			}
+			if name != "" && (!settings.KeepFailedContainers || !t.Failed()) {
+				Expect(platform.Delete.Execute(name)).To(Succeed())
+			}
+		})
+
+		context("app bound to a redis session store", func() {
+			it("writes the session configuration into the dependency php.ini", func() {
+				deployment, logs, err := platform.Deploy.
+					WithServices(map[string]switchblade.Service{
+						"redis-sessions": {
+							"hostname": "redis.example.com",
+							"port":     6379,
+							"password": "secret",
+						},
+					}).
+					Execute(name, filepath.Join(fixtures, "with_sessions"))
+				Expect(err).NotTo(HaveOccurred(), logs.String)
+
+				Eventually(logs.String()).Should(SatisfyAll(
+					ContainSubstring("Running extension Compile phase"),
+					Not(ContainSubstring("Extension compilation failed")),
+				))
+
+				Eventually(deployment).Should(Serve(
+					ContainSubstring("handler=redis|name=PHPSESSIONID"),
+				))
+			})
+		})
+	}
+}