From 9ae61ef4e57258e6749bc2ff7fee5b76c5f5dc3c Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Fri, 30 Oct 2026 14:44:43 +1100 Subject: [PATCH 1/2] Addressed code review: kept the fix-or-post follow-up outside the read-only review and documented the external and merged pull request cases. --- .claude/skills/review-code/SKILL.md | 4 ++-- .vortex/docs/content/development/ai.mdx | 12 ++++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.claude/skills/review-code/SKILL.md b/.claude/skills/review-code/SKILL.md index 3d93a68f67..43998d1961 100644 --- a/.claude/skills/review-code/SKILL.md +++ b/.claude/skills/review-code/SKILL.md @@ -119,8 +119,8 @@ about something missing, such as a test. | Ready after fixes | Important findings and no Critical ones | | Ready to merge | Only Minor findings, non-blocking questions, or no findings | -When there are findings, offer to fix them or post them to the pull -request. Do neither unless the developer asks. +When there are findings, end by noting that fixing them or posting them to +the pull request is a separate request. The review itself does neither. ## Customizing diff --git a/.vortex/docs/content/development/ai.mdx b/.vortex/docs/content/development/ai.mdx index 3d72f56158..36cb29d8ff 100644 --- a/.vortex/docs/content/development/ai.mdx +++ b/.vortex/docs/content/development/ai.mdx @@ -134,10 +134,14 @@ The review checks the change against 3 sources, in this order: updates, tests and front-end code. 3. General engineering judgment. -The review skips anything `ahoy lint` already enforces. It sorts findings -into **Critical**, **Important** and **Minor** and points each one at a -file and line. It ends with a verdict: **Ready to merge**, **Ready after -fixes** or **Needs work**. +For a pull request in another repository, the review uses that +repository's rules and skips the checklist. + +The review skips anything that `ahoy lint` or another lint command in +`AGENTS.md` already enforces. It sorts findings into **Critical**, +**Important** and **Minor** and points each one at a file and line. It +ends with a verdict: **Ready to merge**, **Ready after fixes** or **Needs +work**. A merged or closed pull request gets follow-ups and no verdict. ### Adapt the review to your team From 45bf9d069fa8f6d3ce3b8a913e57498e8e057e23 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Fri, 30 Oct 2026 14:46:06 +1100 Subject: [PATCH 2/2] Updated snapshots. --- .../_baseline/.claude/skills/review-code/SKILL.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/.claude/skills/review-code/SKILL.md b/.vortex/installer/tests/Fixtures/handler_process/_baseline/.claude/skills/review-code/SKILL.md index 1269f48556..538affb691 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/.claude/skills/review-code/SKILL.md +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/.claude/skills/review-code/SKILL.md @@ -119,8 +119,8 @@ about something missing, such as a test. | Ready after fixes | Important findings and no Critical ones | | Ready to merge | Only Minor findings, non-blocking questions, or no findings | -When there are findings, offer to fix them or post them to the pull -request. Do neither unless the developer asks. +When there are findings, end by noting that fixing them or posting them to +the pull request is a separate request. The review itself does neither. ## Customizing