From 890172a632d5ab1589bfc1f4f4f8aa300f73fbfe Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Mon, 16 Nov 2026 08:39:54 +1100 Subject: [PATCH 1/5] [#3328] Failed linting on debug calls left in custom code. --- .../development/code-quality/eslint.mdx | 1 + .../development/code-quality/phpcs.mdx | 12 +++ .vortex/docs/cspell.json | 1 + .vortex/docs/eslint.config.mjs | 2 + .../AsciinemaPlayer/AsciinemaPlayer.js | 1 + .vortex/installer/phpcs.xml | 12 +++ .vortex/tests/phpcs.xml | 12 +++ .../phpunit/Functional/AhoyWorkflowTest.php | 4 + .../Traits/Subtests/SubtestAhoyTrait.php | 73 +++++++++++++++++++ eslint.config.mjs | 1 + phpcs.xml | 12 +++ .../Drupal/EnvironmentSettingsTest.php | 2 +- .../ys_base/tests/src/Traits/AssertTrait.php | 2 +- .../custom/your_site_theme/eslint.config.mjs | 1 + 14 files changed, 134 insertions(+), 2 deletions(-) diff --git a/.vortex/docs/content/development/code-quality/eslint.mdx b/.vortex/docs/content/development/code-quality/eslint.mdx index 7c6c330657..ff106788c8 100644 --- a/.vortex/docs/content/development/code-quality/eslint.mdx +++ b/.vortex/docs/content/development/code-quality/eslint.mdx @@ -113,6 +113,7 @@ On top of the presets, the configuration sets the following rules: |-------------------------------|---------|--------------------------------------------------------------------------| | `prettier/prettier` | Error | Reports every difference from the Prettier formatting. | | `no-console` | Error | Reports console calls, because they print to every visitor's browser. | +| `no-debugger` | Error | Reports `debugger` statements. | | `operator-linebreak` | Error | Requires an operator other than `?` or `:` at the end of a wrapped line. | | `yml/indent` | Error | Requires a 2-space indent in YAML files. | | `max-nested-callbacks` | Warning | Reports callbacks nested more than 3 levels deep. | diff --git a/.vortex/docs/content/development/code-quality/phpcs.mdx b/.vortex/docs/content/development/code-quality/phpcs.mdx index 2b58ff92b6..e2e8d4d0ef 100644 --- a/.vortex/docs/content/development/code-quality/phpcs.mdx +++ b/.vortex/docs/content/development/code-quality/phpcs.mdx @@ -87,6 +87,10 @@ By default, PHPCS checks against the following standards and sniffs: - `DrupalPractice` - Drupal best practices - `Generic.PHP.RequireStrictTypes` - a `declare(strict_types=1);` statement in every file +- `Drupal.Functions.DiscouragedFunctions` - debug calls, reported as + errors instead of the standard's warnings. The `Drupal` standard lists + the Devel helpers such as `dpm()` and `kint()`, plus `eval()` and + `fnmatch()`. The ruleset adds `var_dump()`, `print_r()` and `dump()` - `PHPCompatibility` - compatibility with the PHP version in `testVersion` - `DrevOps` - the DrevOps standard, which requires the following: - Snake_case names for local variables and parameters @@ -96,6 +100,14 @@ By default, PHPCS checks against the following standards and sniffs: `|` and `&` in union and intersection types, set through its `withSpacesAroundOperators` property +To forbid another function, add an `` to the `forbiddenFunctions` +property of `Drupal.Functions.DiscouragedFunctions` in `phpcs.xml`. The +property's `extend="true"` attribute keeps the standard's list: + +```xml + +``` + The ruleset also adds 3 whitespace sniffs from the standards that ship with PHPCS and reports them as warnings. They flag a blank line after a function's opening brace and a blank line before or after a control diff --git a/.vortex/docs/cspell.json b/.vortex/docs/cspell.json index db7e21a182..a5d1cb5f49 100644 --- a/.vortex/docs/cspell.json +++ b/.vortex/docs/cspell.json @@ -61,6 +61,7 @@ "itok", "jsonpath", "kcov", + "kint", "lagooncli", "lagoonhealthz", "lando", diff --git a/.vortex/docs/eslint.config.mjs b/.vortex/docs/eslint.config.mjs index 507d5df64d..146abf7781 100644 --- a/.vortex/docs/eslint.config.mjs +++ b/.vortex/docs/eslint.config.mjs @@ -34,6 +34,8 @@ export default defineConfig( 'react/react-in-jsx-scope': 'off', 'react/prop-types': 'off', 'no-unused-vars': ['error', { argsIgnorePattern: '^_' }], + 'no-console': 'error', + 'no-debugger': 'error', 'prefer-const': 'error', 'no-var': 'error', curly: ['error', 'all'], diff --git a/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js b/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js index f134ec5541..044712a29a 100644 --- a/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js +++ b/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js @@ -91,6 +91,7 @@ const AsciinemaPlayer = ({ } } } catch (error) { + // eslint-disable-next-line no-console console.error('Failed to load Asciinema player:', error); } }; diff --git a/.vortex/installer/phpcs.xml b/.vortex/installer/phpcs.xml index 2bc036c202..5982a3fefb 100644 --- a/.vortex/installer/phpcs.xml +++ b/.vortex/installer/phpcs.xml @@ -15,6 +15,18 @@ + + + + + + + + + + + + diff --git a/.vortex/tests/phpcs.xml b/.vortex/tests/phpcs.xml index a86126bf5a..555d151dbf 100644 --- a/.vortex/tests/phpcs.xml +++ b/.vortex/tests/phpcs.xml @@ -12,6 +12,18 @@ + + + + + + + + + + + + diff --git a/.vortex/tests/phpunit/Functional/AhoyWorkflowTest.php b/.vortex/tests/phpunit/Functional/AhoyWorkflowTest.php index 0206e0fbf0..52ed7e2166 100644 --- a/.vortex/tests/phpunit/Functional/AhoyWorkflowTest.php +++ b/.vortex/tests/phpunit/Functional/AhoyWorkflowTest.php @@ -64,12 +64,16 @@ public function testAhoyWorkflowStateless(): void { $this->subtestAhoyLintBe(); + $this->subtestAhoyLintBeDebugCalls(); + $this->subtestAhoyLintBeRector(); $this->subtestAhoyLintBeBaseline(); $this->subtestAhoyLintFe(); + $this->subtestAhoyLintFeDebugCalls(); + $this->subtestAhoyLintSdc(); $this->subtestAhoyLintTests(); diff --git a/.vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php b/.vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php index 29dfb0a5fb..ad33821f60 100644 --- a/.vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php +++ b/.vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php @@ -502,6 +502,51 @@ protected function subtestAhoyLintBe(string $webroot = 'web'): void { $this->logStepFinish(); } + protected function subtestAhoyLintBeDebugCalls(string $webroot = 'web'): void { + $this->logStepStart(); + + $this->logSubstep('Assert that debug calls in custom code fail BE lint as errors'); + $module_file = $webroot . '/modules/custom/sw_base/sw_base.deploy.php'; + $theme_file = $webroot . '/themes/custom/star_wars/star_wars.theme'; + $this->fileAppend($module_file, "\nvar_dump(1);\nprint_r(1);\ndump(1);\ndpm(1);\nkint(1);\n"); + $this->fileAppend($theme_file, "\nvar_dump(1);\n"); + $this->syncToContainer([$module_file, $theme_file]); + + // 'dpm()' and 'kint()' come from the Drupal standard's own list, so they + // prove the ruleset extends that list instead of replacing it. + $this->cmdFail('ahoy lint-be', [ + '* sw_base.deploy.php', + '* star_wars.theme', + '* The use of function var_dump() is forbidden', + '* The use of function print_r() is forbidden', + '* The use of function dump() is forbidden', + '* The use of function dpm() is forbidden', + '* The use of function kint() is forbidden', + '* Drupal.Functions.DiscouragedFunctions.Found', + '! is discouraged', + '! Drupal.Functions.DiscouragedFunctions.Discouraged', + ], tio: 120, ito: 90, txt: '`ahoy lint-be` fails with errors on debug calls in a custom module and a custom theme'); + + $this->fileRestore($module_file); + $this->fileRestore($theme_file); + $this->syncToContainer([$module_file, $theme_file]); + + $this->logSubstep('Assert that debug calls in contrib and core code are not linted'); + $contrib_dir = $webroot . '/modules/contrib/sw_debug_canary'; + $contrib_file = $contrib_dir . '/sw_debug_canary.module'; + $core_file = $webroot . '/core/sw_debug_canary.php'; + File::dump($contrib_file, "syncToContainer([$contrib_file, $core_file]); + + $this->cmd('ahoy cli vendor/bin/phpcs', '! The use of function var_dump() is forbidden', tio: 120, ito: 90, txt: '`phpcs` passes with debug calls in contrib and core code'); + + $this->removePathHostAndContainer($contrib_dir); + $this->removePathHostAndContainer($core_file); + + $this->logStepFinish(); + } + protected function subtestAhoyLintBeRector(string $webroot = 'web'): void { $this->logStepStart(); @@ -658,6 +703,34 @@ protected function subtestAhoyLintFe(string $webroot = 'web'): void { $this->logStepFinish(); } + protected function subtestAhoyLintFeDebugCalls(string $webroot = 'web'): void { + $this->logStepStart(); + + $canary = "console.log('canary');\ndebugger;\n"; + + // The module and theme linters run in sequence and the first failure stops + // the run, so each location is asserted on its own. + $this->logSubstep('Assert that debug calls in custom module JS fail FE lint'); + $module_file = $webroot . '/modules/custom/sw_base/js/sw_base_debug_canary.js'; + File::dump($module_file, $canary); + $this->syncToContainer($module_file); + + $this->cmdFail('ahoy lint-fe', ['* sw_base_debug_canary.js', '* no-console', '* no-debugger'], tio: 120, ito: 90, txt: '`ahoy lint-fe` fails on `console.log()` and `debugger` in custom module JS'); + + $this->removePathHostAndContainer($module_file); + + $this->logSubstep('Assert that debug calls in custom theme JS fail FE lint'); + $theme_file = $webroot . '/themes/custom/star_wars/js/star_wars_debug_canary.js'; + File::dump($theme_file, $canary); + $this->syncToContainer($theme_file); + + $this->cmdFail('ahoy lint-fe', ['* star_wars_debug_canary.js', '* no-console', '* no-debugger'], tio: 120, ito: 90, txt: '`ahoy lint-fe` fails on `console.log()` and `debugger` in custom theme JS'); + + $this->removePathHostAndContainer($theme_file); + + $this->logStepFinish(); + } + protected function subtestAhoyLintSdc(string $webroot = 'web'): void { $this->logStepStart(); diff --git a/eslint.config.mjs b/eslint.config.mjs index 5ebf1ca5d6..18ddbe2e5f 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -79,6 +79,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/phpcs.xml b/phpcs.xml index 78eead0fbf..ee4b9cd4ef 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -20,6 +20,18 @@ + + + + + + + + + + + + diff --git a/tests/phpunit/Drupal/EnvironmentSettingsTest.php b/tests/phpunit/Drupal/EnvironmentSettingsTest.php index a5783789a0..350cf94e3d 100644 --- a/tests/phpunit/Drupal/EnvironmentSettingsTest.php +++ b/tests/phpunit/Drupal/EnvironmentSettingsTest.php @@ -52,7 +52,7 @@ public function testEnvironmentTypeDetection(array $vars, string $expected_env): $this->requireSettingsFile(); - $this->assertEquals($expected_env, $this->settings['environment'], print_r($vars, TRUE)); + $this->assertEquals($expected_env, $this->settings['environment'], var_export($vars, TRUE)); } /** diff --git a/web/modules/custom/ys_base/tests/src/Traits/AssertTrait.php b/web/modules/custom/ys_base/tests/src/Traits/AssertTrait.php index 814d6479b8..c6ec515067 100644 --- a/web/modules/custom/ys_base/tests/src/Traits/AssertTrait.php +++ b/web/modules/custom/ys_base/tests/src/Traits/AssertTrait.php @@ -32,7 +32,7 @@ public function assertArrayContainsString(string $needle, array $haystack): void return; } } - $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, print_r($haystack, TRUE))); + $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, var_export($haystack, TRUE))); } } diff --git a/web/themes/custom/your_site_theme/eslint.config.mjs b/web/themes/custom/your_site_theme/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/web/themes/custom/your_site_theme/eslint.config.mjs +++ b/web/themes/custom/your_site_theme/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', From 7f77d327fd28c9c2bfeb91ee3428296064c99b59 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Mon, 16 Nov 2026 08:40:08 +1100 Subject: [PATCH 2/5] Updated snapshots. --- .../handler_process/_baseline/eslint.config.mjs | 1 + .../Fixtures/handler_process/_baseline/phpcs.xml | 12 ++++++++++++ .../tests/phpunit/Drupal/EnvironmentSettingsTest.php | 2 +- .../custom/sw_base/tests/src/Traits/AssertTrait.php | 2 +- .../web/themes/custom/star_wars/eslint.config.mjs | 1 + .../custom/sw_base/tests/src/Traits/AssertTrait.php | 2 +- .../themes/custom/star_wars/eslint.config.mjs | 1 + .../handler_process/hosting_acquia/phpcs.xml | 2 +- .../custom/sw_base/tests/src/Traits/AssertTrait.php | 2 +- .../themes/custom/star_wars/eslint.config.mjs | 1 + .../hosting_project_name___acquia/phpcs.xml | 2 +- .../the_force_base/tests/src/Traits/AssertTrait.php | 2 +- .../web/themes/custom/lightsaber/eslint.config.mjs | 1 + .../Fixtures/handler_process/theme_claro/phpcs.xml | 2 +- .../web/themes/custom/light_saber/eslint.config.mjs | 1 + .../Fixtures/handler_process/theme_olivero/phpcs.xml | 2 +- .../Fixtures/handler_process/theme_stark/phpcs.xml | 2 +- .../tools_groups_no_be_tests/phpcs.xml | 2 +- .../tools_groups_no_be_tests_circleci/phpcs.xml | 2 +- .../tools_groups_no_fe_lint_no_theme/phpcs.xml | 2 +- .../phpcs.xml | 2 +- .../handler_process/tools_no_behat/phpcs.xml | 2 +- .../tools_no_behat_circleci/phpcs.xml | 2 +- .../tools_no_eslint_no_theme/phpcs.xml | 2 +- .../tools_no_stylelint_no_theme/phpcs.xml | 2 +- 25 files changed, 36 insertions(+), 18 deletions(-) diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/_baseline/eslint.config.mjs index 5ebf1ca5d6..18ddbe2e5f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/eslint.config.mjs @@ -79,6 +79,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml index cd9bb971b0..946209def5 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml @@ -20,6 +20,18 @@ + + + + + + + + + + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php b/.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php index 0b043eca4e..cf9c2962af 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php @@ -32,7 +32,7 @@ public function testEnvironmentTypeDetection(array $vars, string $expected_env): $this->requireSettingsFile(); - $this->assertEquals($expected_env, $this->settings['environment'], print_r($vars, TRUE)); + $this->assertEquals($expected_env, $this->settings['environment'], var_export($vars, TRUE)); } /** diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Traits/AssertTrait.php b/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Traits/AssertTrait.php index 4e9f0c1d55..2e14ab6816 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Traits/AssertTrait.php +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/modules/custom/sw_base/tests/src/Traits/AssertTrait.php @@ -32,7 +32,7 @@ public function assertArrayContainsString(string $needle, array $haystack): void return; } } - $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, print_r($haystack, TRUE))); + $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, var_export($haystack, TRUE))); } } diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/web/themes/custom/star_wars/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php index 4e9f0c1d55..2e14ab6816 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php @@ -32,7 +32,7 @@ public function assertArrayContainsString(string $needle, array $haystack): void return; } } - $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, print_r($haystack, TRUE))); + $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, var_export($haystack, TRUE))); } } diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/docroot/themes/custom/star_wars/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml index 6710cb5229..937e25c885 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml @@ -13,7 +13,7 @@ tests scripts -@@ -31,10 +31,10 @@ +@@ -43,10 +43,10 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php index 4e9f0c1d55..2e14ab6816 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/modules/custom/sw_base/tests/src/Traits/AssertTrait.php @@ -32,7 +32,7 @@ public function assertArrayContainsString(string $needle, array $haystack): void return; } } - $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, print_r($haystack, TRUE))); + $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, var_export($haystack, TRUE))); } } diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/docroot/themes/custom/star_wars/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml index 6710cb5229..937e25c885 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml @@ -13,7 +13,7 @@ tests scripts -@@ -31,10 +31,10 @@ +@@ -43,10 +43,10 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Traits/AssertTrait.php b/.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Traits/AssertTrait.php index 6b8c984d9f..6a8f4cec85 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Traits/AssertTrait.php +++ b/.vortex/installer/tests/Fixtures/handler_process/names/web/modules/custom/the_force_base/tests/src/Traits/AssertTrait.php @@ -32,7 +32,7 @@ public function assertArrayContainsString(string $needle, array $haystack): void return; } } - $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, print_r($haystack, TRUE))); + $this->fail(sprintf('Failed asserting that string "%s" is present in array %s.', $needle, var_export($haystack, TRUE))); } } diff --git a/.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/names/web/themes/custom/lightsaber/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/eslint.config.mjs b/.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/eslint.config.mjs index 4ef44c137d..e0dad27157 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/eslint.config.mjs +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_custom/web/themes/custom/light_saber/eslint.config.mjs @@ -69,6 +69,7 @@ export default defineConfig( // Kept from the previous ruleset: console calls left in shipped code // print to every visitor's browser. 'no-console': 'error', + 'no-debugger': 'error', 'operator-linebreak': [ 'error', 'after', diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml index f677fe7033..8a6d40db61 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml @@ -1,4 +1,4 @@ -@@ -59,8 +59,4 @@ +@@ -71,8 +71,4 @@ *.test diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml index f677fe7033..8a6d40db61 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml @@ -1,4 +1,4 @@ -@@ -59,8 +59,4 @@ +@@ -71,8 +71,4 @@ *.test diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml index f677fe7033..8a6d40db61 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml @@ -1,4 +1,4 @@ -@@ -59,8 +59,4 @@ +@@ -71,8 +71,4 @@ *.test diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml index f677fe7033..8a6d40db61 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml @@ -1,4 +1,4 @@ -@@ -59,8 +59,4 @@ +@@ -71,8 +71,4 @@ *.test diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml index cc1b02ed03..d1d74416f3 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml @@ -6,7 +6,7 @@ web/sites/default/settings.php web/sites/default/includes tests -@@ -31,10 +30,6 @@ +@@ -43,10 +42,6 @@ From fbc350f6f4e67c5694e8cad5fdac323b8ae24567 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Mon, 16 Nov 2026 08:48:43 +1100 Subject: [PATCH 3/5] [#3328] Allowed 'console.warn()' and 'console.error()' in the docs site instead of suppressing 'no-console'. --- .vortex/docs/eslint.config.mjs | 2 +- .vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.vortex/docs/eslint.config.mjs b/.vortex/docs/eslint.config.mjs index 146abf7781..ec85decd41 100644 --- a/.vortex/docs/eslint.config.mjs +++ b/.vortex/docs/eslint.config.mjs @@ -34,7 +34,7 @@ export default defineConfig( 'react/react-in-jsx-scope': 'off', 'react/prop-types': 'off', 'no-unused-vars': ['error', { argsIgnorePattern: '^_' }], - 'no-console': 'error', + 'no-console': ['error', { allow: ['warn', 'error'] }], 'no-debugger': 'error', 'prefer-const': 'error', 'no-var': 'error', diff --git a/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js b/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js index 044712a29a..f134ec5541 100644 --- a/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js +++ b/.vortex/docs/src/components/AsciinemaPlayer/AsciinemaPlayer.js @@ -91,7 +91,6 @@ const AsciinemaPlayer = ({ } } } catch (error) { - // eslint-disable-next-line no-console console.error('Failed to load Asciinema player:', error); } }; From 4f61dee2aaf2df38ee2a8bdf5c541a36cfd65703 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Mon, 16 Nov 2026 09:07:22 +1100 Subject: [PATCH 4/5] [#3328] Reordered 'phpcs.xml' to put arguments and config before rules, with the debug calls rule last. --- phpcs.xml | 58 +++++++++++++++++++++++++++---------------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/phpcs.xml b/phpcs.xml index ee4b9cd4ef..e70489e7d5 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -2,6 +2,16 @@ Custom PHPCS Standard, based on Drupal standards. + + + + + + + + + + web/modules/custom web/themes/custom web/sites/default/settings.php @@ -9,6 +19,13 @@ tests scripts + + web\/themes\/custom\/.*\/build\/.* + web\/themes\/custom\/.*\/fonts\/.* + web\/themes\/custom\/.*\/images\/.* + web\/themes\/custom\/.*\/node_modules\/.* + *\.min\.* + @@ -20,35 +37,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - web\/themes\/custom\/.*\/build\/.* - web\/themes\/custom\/.*\/fonts\/.* - web\/themes\/custom\/.*\/images\/.* - web\/themes\/custom\/.*\/node_modules\/.* - *\.min\.* - warning @@ -77,4 +65,16 @@ *\/tests\/behat\/bootstrap/*\.php + + + + + + + + + + + + From dd4961e3e64ae3cb10ccd272dd05092cd350d296 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Mon, 16 Nov 2026 09:19:16 +1100 Subject: [PATCH 5/5] Updated snapshots. --- .../handler_process/_baseline/phpcs.xml | 58 +++++++++---------- .../handler_process/hosting_acquia/phpcs.xml | 11 ++-- .../hosting_project_name___acquia/phpcs.xml | 11 ++-- .../handler_process/theme_claro/phpcs.xml | 10 ++-- .../handler_process/theme_olivero/phpcs.xml | 10 ++-- .../handler_process/theme_stark/phpcs.xml | 10 ++-- .../tools_groups_no_be_tests/phpcs.xml | 7 ++- .../phpcs.xml | 7 ++- .../phpcs.xml | 10 ++-- .../phpcs.xml | 10 ++-- .../handler_process/tools_no_behat/phpcs.xml | 7 ++- .../tools_no_behat_circleci/phpcs.xml | 7 ++- .../tools_no_eslint_no_theme/phpcs.xml | 10 ++-- .../tools_no_stylelint_no_theme/phpcs.xml | 10 ++-- 14 files changed, 92 insertions(+), 86 deletions(-) diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml index 946209def5..d5be956a0c 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpcs.xml @@ -2,6 +2,16 @@ Custom PHPCS Standard, based on Drupal standards. + + + + + + + + + + web/modules/custom web/themes/custom web/sites/default/settings.php @@ -9,6 +19,13 @@ tests scripts + + web\/themes\/custom\/.*\/build\/.* + web\/themes\/custom\/.*\/fonts\/.* + web\/themes\/custom\/.*\/images\/.* + web\/themes\/custom\/.*\/node_modules\/.* + *\.min\.* + @@ -20,35 +37,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - web\/themes\/custom\/.*\/build\/.* - web\/themes\/custom\/.*\/fonts\/.* - web\/themes\/custom\/.*\/images\/.* - web\/themes\/custom\/.*\/node_modules\/.* - *\.min\.* - warning @@ -75,4 +63,16 @@ *\/tests\/behat\/bootstrap/*\.php + + + + + + + + + + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml index 937e25c885..eccff9ac08 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpcs.xml @@ -1,6 +1,6 @@ -@@ -2,10 +2,10 @@ - - Custom PHPCS Standard, based on Drupal standards. +@@ -12,18 +12,18 @@ + + - web/modules/custom - web/themes/custom @@ -13,9 +13,6 @@ tests scripts -@@ -43,10 +43,10 @@ - - - web\/themes\/custom\/.*\/build\/.* - web\/themes\/custom\/.*\/fonts\/.* @@ -27,4 +24,4 @@ + docroot\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml index 937e25c885..eccff9ac08 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpcs.xml @@ -1,6 +1,6 @@ -@@ -2,10 +2,10 @@ - - Custom PHPCS Standard, based on Drupal standards. +@@ -12,18 +12,18 @@ + + - web/modules/custom - web/themes/custom @@ -13,9 +13,6 @@ tests scripts -@@ -43,10 +43,10 @@ - - - web\/themes\/custom\/.*\/build\/.* - web\/themes\/custom\/.*\/fonts\/.* @@ -27,4 +24,4 @@ + docroot\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml index 8a6d40db61..189b662b69 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpcs.xml @@ -1,4 +1,4 @@ -@@ -71,8 +71,4 @@ +@@ -59,11 +59,6 @@ *.test @@ -6,4 +6,7 @@ - - *\/tests\/behat\/bootstrap/*\.php - - +- + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml index 8a6d40db61..189b662b69 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpcs.xml @@ -1,4 +1,4 @@ -@@ -71,8 +71,4 @@ +@@ -59,11 +59,6 @@ *.test @@ -6,4 +6,7 @@ - - *\/tests\/behat\/bootstrap/*\.php - - +- + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml index 8a6d40db61..189b662b69 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/phpcs.xml @@ -1,4 +1,4 @@ -@@ -71,8 +71,4 @@ +@@ -59,11 +59,6 @@ *.test @@ -6,4 +6,7 @@ - - *\/tests\/behat\/bootstrap/*\.php - - +- + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml index 8a6d40db61..189b662b69 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/phpcs.xml @@ -1,4 +1,4 @@ -@@ -71,8 +71,4 @@ +@@ -59,11 +59,6 @@ *.test @@ -6,4 +6,7 @@ - - *\/tests\/behat\/bootstrap/*\.php - - +- + + + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - + diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml index d1d74416f3..f51a74c464 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpcs.xml @@ -1,13 +1,13 @@ -@@ -3,7 +3,6 @@ - Custom PHPCS Standard, based on Drupal standards. +@@ -13,7 +13,6 @@ + web/modules/custom - web/themes/custom web/sites/default/settings.php web/sites/default/includes tests -@@ -43,10 +42,6 @@ - +@@ -20,10 +19,6 @@ + scripts - web\/themes\/custom\/.*\/build\/.* @@ -16,4 +16,4 @@ - web\/themes\/custom\/.*\/node_modules\/.* *\.min\.* - +