From 6a0ac9fb496c27b7e4fdb92ed5975e85ebe7c213 Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Thu, 1 Oct 2026 11:28:22 -0500 Subject: [PATCH] Sync the shared review stopping rules The commit, pull request, review, and landing rules are shared with firstdraft/firstdraft and firstdraft/skills, and the service repository is changing two of them to cut duplicate review sessions. An amendment that only applies accepted findings no longer needs a re-review, and a review whose only trigger is an instruction-policy change runs once at high effort instead of max. Keep this copy in step so following it does not bring the extra sessions back. --- CONTRIBUTING.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 83b4057..0bd6ba2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -70,7 +70,8 @@ codex plugin add claude-review@cross-review To run a review: 1. Start a `new` session over the branch, such as `new branch main`, or over an explicit range with - `new range ..`. + `new range ..`. When an instruction-policy change is the only reason for review, run that one session + with `--effort high` instead of the default `max`. 2. Pass the service repository's `docs/review-focus.md` with `--focus-file`, from a sibling `firstdraft/firstdraft` checkout or fetched into the ignored `tmp/`: @@ -84,8 +85,9 @@ To run a review: 3. When the review finishes, the host agent runs `cite` and checks each finding against the cited lines before relaying it. -4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Review an amendment - in the same session with `range ..HEAD`. +4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Re-review an + amendment only when it does more than apply accepted findings, in the same session with + `range ..HEAD`. Do not merge while a required review is still running. Review third-party changes, such as Dependabot or outside pull requests, with `--capability read-only`.