From a90007d8399ee642f4d06521e083da0e5d17a20d Mon Sep 17 00:00:00 2001 From: "lab-tools-builder.ccd1c2" Date: Wed, 18 Nov 2026 15:12:59 +0100 Subject: [PATCH] chore(backlog): lab names stale phone pieces, done (lab-tools #170) --- data/backlog.json | 2 +- data/session_log.json | 1 + docs/backlog.md | 4 ++-- docs/index.md | 2 +- docs/session_log.md | 24 ++++++++++++++++++++++++ 5 files changed, 29 insertions(+), 4 deletions(-) diff --git a/data/backlog.json b/data/backlog.json index e62e426..f7b28b2 100644 --- a/data/backlog.json +++ b/data/backlog.json @@ -172,5 +172,5 @@ {"project":"linux-phone-oco/lab-tools","id":"test-bisect-parallel-flake","title":"bringup_bisect_runs_declared_series fails in a parallel workspace run, passes alone","status":"open","note":"Sign (coordinator, 2026-11-18): failed once in a parallel workspace run, passes alone. Likely shared state between tests (a fixed temp path, cwd, or env var); give each test its own dir/env.","opened":"2026-11-18","waits":null,"blocked_by":null,"hardware":null,"needs":"build","device":"google-walleye","proof":"cargo test --workspace passes 20 runs in a row with default parallelism","rank":10,"about":"bringup"} {"project":"linux-phone-oco/lab-tools","id":"test-hold-parallel-flake","title":"hold::tests::the_phone_is_held_by_one_change_at_a_time fails in a parallel workspace run, passes alone","status":"open","note":"Sign (coordinator, 2026-11-18): failed once in a parallel workspace run, passes alone. Likely a shared lease file or lock path across tests; give each test its own.","opened":"2026-11-18","waits":null,"blocked_by":null,"hardware":null,"needs":"build","device":"xiaomi-surya","proof":"cargo test --workspace passes 20 runs in a row with default parallelism","rank":10,"about":null} {"project":"linux-phone-oco/lab-tools","id":"sxmo-utils-lab-apk-deliver","title":"Build, sign and publish the sxmo-utils lab apk as the sxmo-utils@lab repository","status":"open","note":"Blocked on the conveyor (linux-package-distribution-oco/conveyor, alpine.yml v1), not on lab-tools. Read 2026-11-18: it takes a declaration input and a tag, but (1) it copies only the APKBUILD into the build folder, while sxmo-utils has 7 local source files beside it (rootfs-*, *.post-install), so abuild fetch/verify fails; (2) it builds one Pages site per repository from this run's artifacts alone, so a second package in lab-tools would replace lpoco-health's repository (and the verify step reads the page for one NAME). Needs of the conveyor: copy the APKBUILD's whole folder; merge into the existing site (or one site per package), verify per package. Then lab-tools adds packaging/sxmo-utils/conveyor.toml (tag-prefix sxmo-utils-v, tag sxmo-utils-v1.18.1_p20261118) and a second packages job with declaration:. Nothing landed in lab-tools: a trigger now would clobber the live lpoco-health page.","opened":"2026-11-18","waits":"a conveyor tag (linux-package-distribution-oco/conveyor alpine.yml) that copies the APKBUILD folder whole and deploys a second package without replacing the first, with verify per package","blocked_by":null,"hardware":null,"needs":"build","device":"xiaomi-surya","proof":"suspend-retry-backs-off","rank":4,"about":"sxmo-utils-lab-apk"} -{"project":"linux-phone-oco/lab-tools","id":"phone-pieces-drift-in-lab","title":"lpoco lab names a stale phone-side piece at every change's end, from the report it reads back","status":"open","note":"Rest of phone-pieces-drift-named: reuse lpoco_host::stale_pieces. Also from review: picking the newest report by file name assumes names sort by time (check that).","opened":"2026-11-18","waits":null,"blocked_by":null,"hardware":null,"needs":"build","device":"xiaomi-surya","proof":"a test in lab-tools lpoco/tests (to write, failing first): after a change the lab output names a piece off main","rank":6,"about":"phone-pieces-drift-named"} +{"project":"linux-phone-oco/lab-tools","id":"phone-pieces-drift-in-lab","title":"lpoco lab names a stale phone-side piece at every change's end, from the report it reads back","status":"done","note":"2026-11-18, lab-tools-builder: done (lab-tools #170, main 27bd466). lpoco-lab test and health name a stale phone piece after the run, from the report just read back, judged by lpoco_host::stale_lines (shared with lpoco host check). Proof: host/tests/phone_pieces.rs the_lab_names_a_piece_off_main_from_the_report_it_reads_back (seen failing first) and the_lines_name_a_package_off_its_pin. Not tested end to end against a phone: devlab's wiring (health.rs name_stale_pieces) has no test of its own. Note: the commit named is now the oldest holding the stale blob (changes host check output). Report-name ordering checked: names are YYYYMMDD-HHMMSS, so the greatest sorts newest.","opened":"2026-11-18","waits":null,"blocked_by":null,"hardware":null,"needs":"build","device":"xiaomi-surya","proof":"a test in lab-tools lpoco/tests (to write, failing first): after a change the lab output names a piece off main","rank":6,"about":"phone-pieces-drift-named"} {"project":"linux-phone-oco/lab-tools","id":"host-plan-unreadable-not-new","title":"lpoco host records each root file it installs, so plan reads an unreadable one as up to date","status":"open","note":"Coordinator, 2026-11-18: when lpoco-host installs a root file, it records the staged content's hash in user state (~/.local/state/lpoco-host, or ~/.cache/lpoco-host). Plan then treats a root file it cannot read as up to date when the staged hash matches the recorded one and its check passes (for 50-lpoco.rules: the share check), and as changed only when the staged content differs. Sign: planning 0.15.0 named /etc/polkit-1/rules.d/50-lpoco.rules '(new)' though the author's 0.14.2 prepare installed it at about 15:00 and the share check passed - the directory is root-only. The same limit applies to NetworkManager keyfiles (part 6b). Bootstrap: the lab has no record yet. Consider recording without root once a check proves the file in place (e.g. lpoco host check passing the share check writes the record for the staged hash), so no sudo is asked for an unchanged file. Then orchestration runs the 0.15.0 prepare itself, with 0 root commands.","opened":"2026-11-18","waits":null,"blocked_by":null,"hardware":null,"needs":"build","device":"xiaomi-surya","proof":"host plan tests from fixtures: (1) a root file under an unreadable directory, whose staged content hashes to the hash recorded at its last install, is planned up to date with 0 root commands; (2) changed staged content is planned as a root install; (3) with no record, it is named as unreadable and not known, never '(new)'; (4) prepare now records the hash after each root install it runs","rank":5,"about":"lpoco-host-rest"} diff --git a/data/session_log.json b/data/session_log.json index a1fe210..4ee9d72 100644 --- a/data/session_log.json +++ b/data/session_log.json @@ -114,3 +114,4 @@ {"project":"linux-phone-oco/lab-tools","id":"2026-11-18-sxmo-apk-deliver-blocked","entry_date":"2026-11-18","title":"sxmo-utils lab apk delivery: blocked on the conveyor","done":"Read the conveyor's alpine.yml against packaging/sxmo-utils and lab-tools' packages.yml; found two gaps (sibling source files not copied; one Pages site per repository, replaced by each run). Recorded them on the row; changed nothing in the conveyor or lab-tools.","considered":"A second declaration plus a second job in lab-tools alone (fixes neither gap); a workflow of our own that builds and signs (copies the conveyor, against its idea: called, not copied).","rejected":"Landing the declaration and job now: the first run would replace the lpoco-health repository on the live page and fail on the missing sources.","date":null,"about":"sxmo-utils-lab-apk-deliver"} {"project":"linux-phone-oco/lab-tools","id":"2026-11-18-lab-tools-builder-host-install-atomic","entry_date":"2026-11-18","title":"lpoco host: atomic install","done":"Test first (old script run by bash while prepare replaces it; failed on the in-place copy), then replace_file: temp beside, fsync, rename, fsync dir; used for Copy, Stamp and the unit. Programmer review found a flaky test (text file busy on exec, shell-dependent, no deadline): fixed by running it via /bin/bash with a deadline and a release guard.","considered":"Cargo install: left to cargo's own rename.","rejected":"Writing in place with a lock: a reader of a shell script holds no lock. Test via exec of the fresh file: races with parallel tests (text file busy).","date":null,"about":"host-install-atomic"} {"project":"linux-phone-oco/lab-tools","id":"2026-11-18-lpoco-host-check-names-stale-phone-side-pieces","entry_date":"2026-11-18","title":"lpoco host check names stale phone-side pieces","done":"Wrote host/tests/phone_pieces.rs first (failing), built blob_id, stale_pieces, Stale and check's print_stale_pieces in lpoco-host; landed as lab-tools PR 165, read back from main.","considered":"Making a stale piece fail the check: it only names it, as the item asks. Naming a missing piece as its own finding.","rejected":"My first report format (test piece / blob word): invented; review found health's 94-lab-pieces.sh writes piece-file:PATH and piece-package-NAME rows, so the parser follows those. Silent skips of unreadable lines: now an error and 'not measured'.","date":null,"about":"phone-pieces-drift-named"} +{"project":"linux-phone-oco/lab-tools","id":"2026-11-18-lab-names-stale-phone-pieces","entry_date":"2026-11-18","title":"lab names stale phone pieces","done":"lpoco-lab test/health print which phone-side piece the run's report holds off origin/main; logic moved to lpoco_host::stale_lines and shared with lpoco host check (#170).","considered":"Printing from run_checks; judging only the report's JSON rows since phone stdout can carry noise; naming the oldest commit holding the blob.","rejected":"Reading device.toml from the manifest dir (a --device file of another name would be misjudged): the given file path is used. Printing before the pass/fail table: now printed after.","date":null,"about":"phone-pieces-drift-named"} diff --git a/docs/backlog.md b/docs/backlog.md index 5181e33..4933957 100644 --- a/docs/backlog.md +++ b/docs/backlog.md @@ -4313,10 +4313,10 @@ Project : linux-phone-oco/lab-tools Status -: open +: done Note -: Rest of phone-pieces-drift-named: reuse lpoco_host::stale_pieces. Also from review: picking the newest report by file name assumes names sort by time (check that). +: 2026-11-18, lab-tools-builder: done (lab-tools #170, main 27bd466). lpoco-lab test and health name a stale phone piece after the run, from the report just read back, judged by lpoco_host::stale_lines (shared with lpoco host check). Proof: host/tests/phone_pieces.rs the_lab_names_a_piece_off_main_from_the_report_it_reads_back (seen failing first) and the_lines_name_a_package_off_its_pin. Not tested end to end against a phone: devlab's wiring (health.rs name_stale_pieces) has no test of its own. Note: the commit named is now the oldest holding the stale blob (changes host check output). Report-name ordering checked: names are YYYYMMDD-HHMMSS, so the greatest sorts newest. Opened : 2026-11-18 diff --git a/docs/index.md b/docs/index.md index c64efbb..ebff45e 100644 --- a/docs/index.md +++ b/docs/index.md @@ -22,7 +22,7 @@ The memory of linux-phone-oco, whose goal is Linux phones as good as Android for - [Platforms](platforms.md): 7 - [Problems](problems.md): 17 - [Research](research.md): 54 -- [Session Log](session_log.md): 116 +- [Session Log](session_log.md): 117 - [Shell Releases](shell_releases.md): 2 - [Sources](sources.md): 232 - [Summaries](summaries.md): 7 diff --git a/docs/session_log.md b/docs/session_log.md index ae3b0b2..a4542d6 100644 --- a/docs/session_log.md +++ b/docs/session_log.md @@ -2576,3 +2576,27 @@ Rejected About : phone-pieces-drift-named + +--- + + + +### lab names stale phone pieces + +Project +: linux-phone-oco/lab-tools + +Entry date +: 2026-11-18 + +Done +: lpoco-lab test/health print which phone-side piece the run's report holds off origin/main; logic moved to lpoco_host::stale_lines and shared with lpoco host check (#170). + +Considered +: Printing from run_checks; judging only the report's JSON rows since phone stdout can carry noise; naming the oldest commit holding the blob. + +Rejected +: Reading device.toml from the manifest dir (a --device file of another name would be misjudged): the given file path is used. Printing before the pass/fail table: now printed after. + +About +: phone-pieces-drift-named