From 334fea29b37bc1fac97b84da13ab6560a9bc8f33 Mon Sep 17 00:00:00 2001 From: Mauri de Souza Meneguzzo Date: Tue, 3 Nov 2026 18:44:49 -0300 Subject: [PATCH] all: test against go1.27.3 go1.27.3 is the latest 1.27 release. The Makefile pins it, and go.mod gets a toolchain go1.27.3 line, so the script suite and CI use it too: script_test.go runs the scripts with the toolchain go.mod names (goModToolchain), and actions/setup-go reads the same file. Bumping only the Makefile, as #1 does, would have left every script, and the claim that flag_methods_ice.txt checks the crash on 1.27.3, on go1.27.1. The go line stays at 1.27.1, the first release whose simd package works with the code loopvec generates (go1.27.0 compiles ShiftAllRight with a uint8 count), so go install still accepts a 1.27.1 toolchain. go1.27.3's simd package has the same methods as go1.27.1's: make generate only changes the header of caps_gen.go. The -methods internal compiler error (golang/go#80657) is still there, and flag_methods_ice.txt now checks that on go1.27.3. --- BUGS.md | 6 +++--- Makefile | 2 +- go.mod | 2 ++ internal/loopir/caps_gen.go | 2 +- testdata/flag_methods_ice.txt | 2 +- 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/BUGS.md b/BUGS.md index 843087e..55231c5 100644 --- a/BUGS.md +++ b/BUGS.md @@ -2,11 +2,11 @@ loopvec rewrites code to use `GOEXPERIMENT=simd`, which is new, so most of what it hits is in the Go toolchain. This file lists the Go issues that affect loopvec. "tip" means -gotip, "1.27.1" is the release toolchain loopvec is tested against. +gotip, "1.27.3" is the release toolchain loopvec is tested against. | Issue | Status | Affects | loopvec's answer | |---|---|---|---| -| [#80657](https://github.com/golang/go/issues/80657) simd in a method: internal compiler error | fixed on tip (CL 839405), still crashes on 1.27.1 | `-methods` | methods are skipped unless `-methods` is passed | +| [#80657](https://github.com/golang/go/issues/80657) simd in a method: internal compiler error | fixed on tip (CL 839405), still crashes on 1.27.3 | `-methods` | methods are skipped unless `-methods` is passed | | [#80835](https://github.com/golang/go/issues/80835) legacy SSE encodings in functions using simd cause AVX-SSE transition penalties | open, fix pending (CLs 825145, 825146, in tip) | speed of any scalar float code that runs after a rewritten loop, in the same function or another | none; the portable `simd` package has no `ClearAVXUpperBits` | | [#81844](https://github.com/golang/go/issues/81844) blank identifier parameters rejected | fixed on tip (CL 841145) | every rewrite of a function with a `_` parameter | the generated file renames them `_p0`, `_p1`, ... | | [#81845](https://github.com/golang/go/issues/81845) calls left unresolved when inlined into a package initializer | closed as a duplicate of [#80689](https://github.com/golang/go/issues/80689), which is open | loops in package-level `var x = func() {...}()` | not rewritten (the generated initializer fails to link), see `package_initializer_no_rewrite.txt` and `toolexec_package_initializer.txt` | @@ -19,7 +19,7 @@ gotip, "1.27.1" is the release toolchain loopvec is tested against. A function with a receiver that contains simd code failed to compile with `internal compiler error: missing Types entry`. loopvec does not rewrite loops in methods -by default; `-methods` turns it on. The fix is on tip. On 1.27.1 the crash is still there, +by default; `-methods` turns it on. The fix is on tip. On 1.27.3 the crash is still there, and `flag_methods_ice.txt` pins it, so that test starts failing when the pinned toolchain gets the fix. Reported by someone else; the fix is [CL 839405](https://go.dev/cl/839405). diff --git a/Makefile b/Makefile index b75e67b..ac89073 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -export GOTOOLCHAIN ?= go1.27.1 +export GOTOOLCHAIN ?= go1.27.3 .DEFAULT_GOAL := build diff --git a/go.mod b/go.mod index 80c0f21..f1a8121 100644 --- a/go.mod +++ b/go.mod @@ -2,6 +2,8 @@ module github.com/mauri870/loopvec go 1.27.1 +toolchain go1.27.3 + require ( golang.org/x/tools v0.52.1-0.20261103172851-aba6dfd3c19d rsc.io/script v0.0.2 diff --git a/internal/loopir/caps_gen.go b/internal/loopir/caps_gen.go index bccacfa..ba7ddff 100644 --- a/internal/loopir/caps_gen.go +++ b/internal/loopir/caps_gen.go @@ -1,4 +1,4 @@ -// Code generated by capsgen from the simd package of go1.27.1. DO NOT EDIT. +// Code generated by capsgen from the simd package of go1.27.3. DO NOT EDIT. package loopir diff --git a/testdata/flag_methods_ice.txt b/testdata/flag_methods_ice.txt index 0948c91..c2ec597 100644 --- a/testdata/flag_methods_ice.txt +++ b/testdata/flag_methods_ice.txt @@ -1,4 +1,4 @@ -# -methods rewrites method bodies, but go1.27.1 cannot compile them under +# -methods rewrites method bodies, but go1.27.3 cannot compile them under # GOEXPERIMENT=simd: the compiler crashes (golang/go#80657, fixed in later # toolchains). This pins the crash so the README limitation stays accurate. # When this script starts failing on a newer toolchain, the limitation is gone: