From b5726c5127cd61df6f64aaaed416bf48617edfbd Mon Sep 17 00:00:00 2001 From: vedchaudhari Date: Mon, 16 Nov 2026 22:38:40 +0530 Subject: [PATCH] fs: restore stack traces of fs/promises stat permission errors Since stat() started going through raceWithSignal(), permission errors from fsPromises.stat() have had no stack frames. The binding rejects them right away, and raceWithSignal() returned that promise from an async function without awaiting it, so nothing was awaiting it yet when the stack was captured. Return the promise as is when there is no signal, so stat() awaits it directly again. Refs: https://github.com/nodejs/node/pull/63143 Signed-off-by: vedchaudhari --- lib/internal/fs/promises.js | 6 +++++- test/parallel/test-permission-fs-promises-stack-trace.js | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js index 5f9765d0cf35..9696012b0c2c 100644 --- a/lib/internal/fs/promises.js +++ b/lib/internal/fs/promises.js @@ -1218,8 +1218,12 @@ function rejectWithReason(signal, reject) { }; } -async function raceWithSignal(opPromise, signal) { +function raceWithSignal(opPromise, signal) { if (!signal) return opPromise; + return raceWithAbortSignal(opPromise, signal); +} + +async function raceWithAbortSignal(opPromise, signal) { const { promise: abortPromise, reject } = PromiseWithResolvers(); // eslint-disable-next-line no-unused-vars using _ = EventEmitter.addAbortListener(signal, diff --git a/test/parallel/test-permission-fs-promises-stack-trace.js b/test/parallel/test-permission-fs-promises-stack-trace.js index 7160473173ea..7a9999c979aa 100644 --- a/test/parallel/test-permission-fs-promises-stack-trace.js +++ b/test/parallel/test-permission-fs-promises-stack-trace.js @@ -16,19 +16,21 @@ const { status, stderr } = spawnSync( '-e', ` const assert = require('assert'); - const { readFile, writeFile, appendFile } = require('fs/promises'); + const { readFile, writeFile, appendFile, stat } = require('fs/promises'); const target = ${JSON.stringify(tmpdir.resolve('file'))}; function readCaller() { return readFile(target); } function writeCaller() { return writeFile(target, 'data'); } function appendCaller() { return appendFile(target, 'data'); } async function awaitAppendCaller() { await appendFile(target, 'data'); } + async function awaitStatCaller() { await stat(target); } const cases = [ [readCaller, /at readCaller /], [writeCaller, /at writeCaller /], [appendCaller, /at appendCaller /], [awaitAppendCaller, /at awaitAppendCaller /], + [awaitStatCaller, /at async awaitStatCaller /], ]; let checked = 0; for (const [caller, stack] of cases) {