From c49a65346c59bbde095424e9374bc65ddecea8c8 Mon Sep 17 00:00:00 2001 From: JuHyeong424 Date: Sat, 21 Nov 2026 01:03:28 +0900 Subject: [PATCH] dgram: fix abort on negative zero buffer size The size check accepts -0, but the binding asserts IsUint32(), which V8 reports as false for -0, so setRecvBufferSize(-0) and setSendBufferSize(-0) abort the process. Coerce the value to +0. Signed-off-by: JuHyeong424 --- lib/dgram.js | 3 ++- test/parallel/test-dgram-negative-zero.js | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-dgram-negative-zero.js diff --git a/lib/dgram.js b/lib/dgram.js index 653cf6a26305..5d96ada84081 100644 --- a/lib/dgram.js +++ b/lib/dgram.js @@ -250,7 +250,8 @@ function bufferSize(self, size, buffer) { throw new ERR_SOCKET_BAD_BUFFER_SIZE(); const ctx = {}; - const ret = self[kStateSymbol].handle.bufferSize(size, buffer, ctx); + // Coerce -0 to +0, which the binding does not treat as a Uint32. + const ret = self[kStateSymbol].handle.bufferSize(size >>> 0, buffer, ctx); if (ret === undefined) { throw new ERR_SOCKET_BUFFER_SIZE(ctx); } diff --git a/test/parallel/test-dgram-negative-zero.js b/test/parallel/test-dgram-negative-zero.js new file mode 100644 index 000000000000..a59fc93a5a26 --- /dev/null +++ b/test/parallel/test-dgram-negative-zero.js @@ -0,0 +1,12 @@ +'use strict'; + +const common = require('../common'); +const dgram = require('dgram'); + +const socket = dgram.createSocket('udp4'); + +socket.bind(0, common.mustCall(() => { + socket.setRecvBufferSize(-0); + socket.setSendBufferSize(-0); + socket.close(); +}));