From 2aae57c2ed73fb621d26535c62d5a20f0942e13f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fatih=20G=C3=BCzel?= Date: Sun, 22 Nov 2026 21:55:35 +0300 Subject: [PATCH] deps: v8: cherry-pick e1686cd20e83 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit report immutable ArrayBuffers as non-detachable so the existing node-api check returns napi_detachable_arraybuffer_expected. Refs: https://github.com/v8/v8/commit/e1686cd20e836bead6287baa2183d182bbcb8e9f Refs: https://github.com/nodejs/node/pull/67388 Signed-off-by: Fatih Güzel --- common.gypi | 2 +- deps/v8/AUTHORS | 1 + deps/v8/include/v8-array-buffer.h | 2 +- deps/v8/src/api/api.cc | 1 + deps/v8/test/cctest/test-api-array-buffer.cc | 1 + 5 files changed, 5 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index ec134afcebac..ea723efd0f24 100644 --- a/common.gypi +++ b/common.gypi @@ -50,7 +50,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.4', + 'v8_embedder_string': '-node.5', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/AUTHORS b/deps/v8/AUTHORS index 4e43ea3d7e14..10f124a54871 100644 --- a/deps/v8/AUTHORS +++ b/deps/v8/AUTHORS @@ -142,6 +142,7 @@ Elisha Hollander Eric Rannaud Erich Ocean Evan Lucas +Fatih Güzel Fedor Indutny Felix Geisendörfer Feng Yu diff --git a/deps/v8/include/v8-array-buffer.h b/deps/v8/include/v8-array-buffer.h index 912098a91a92..d347a02e0fe6 100644 --- a/deps/v8/include/v8-array-buffer.h +++ b/deps/v8/include/v8-array-buffer.h @@ -159,7 +159,7 @@ class V8_EXPORT ArrayBufferBase : public Object { /** * Returns true if this ArrayBuffer may be detached. Always false for - * SharedArrayBuffer. + * immutable ArrayBuffers and SharedArrayBuffers. */ bool IsDetachable() const; diff --git a/deps/v8/src/api/api.cc b/deps/v8/src/api/api.cc index 5dacb03acbfe..a375830687f9 100644 --- a/deps/v8/src/api/api.cc +++ b/deps/v8/src/api/api.cc @@ -9238,6 +9238,7 @@ bool v8::ArrayBufferBase::IsShared() const { } bool v8::ArrayBufferBase::IsDetachable() const { + if (IsImmutable()) return false; return Utils::OpenDirectHandle(this)->is_detachable(); } diff --git a/deps/v8/test/cctest/test-api-array-buffer.cc b/deps/v8/test/cctest/test-api-array-buffer.cc index 8006f72c6474..57a4ecd3447d 100644 --- a/deps/v8/test/cctest/test-api-array-buffer.cc +++ b/deps/v8/test/cctest/test-api-array-buffer.cc @@ -1305,6 +1305,7 @@ TEST(ArrayBuffer_ImmutableBackingStore) { v8::ArrayBuffer::New(isolate, shared_backing_store); CHECK(ab->IsImmutable()); + CHECK(!ab->IsDetachable()); } TEST(ArrayBuffer_CopyArrayBufferBytes) {