From 366f741969bfcfac94094fdf7b6165e4cb1e344e Mon Sep 17 00:00:00 2001 From: Hendrik Mennen Date: Tue, 17 Nov 2026 09:09:57 +0100 Subject: [PATCH] [Php70] Treat unescaped { as literal in EregToPcreTransformer A { that is not followed by a digit, e.g. ereg_replace('{[0-9]*}', ...), threw InvalidEregException and aborted the whole file. Like in the original ereg implementation it is now a literal brace. --- .../literal_brace_before_non_digit.php.inc | 21 +++++++++++++++++++ rules/Php70/EregToPcreTransformer.php | 7 ++----- 2 files changed, 23 insertions(+), 5 deletions(-) create mode 100644 rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/literal_brace_before_non_digit.php.inc diff --git a/rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/literal_brace_before_non_digit.php.inc b/rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/literal_brace_before_non_digit.php.inc new file mode 100644 index 00000000000..8b4e0f823fe --- /dev/null +++ b/rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/literal_brace_before_non_digit.php.inc @@ -0,0 +1,21 @@ + +----- + diff --git a/rules/Php70/EregToPcreTransformer.php b/rules/Php70/EregToPcreTransformer.php index b2ef75e1c13..63c5daceda2 100644 --- a/rules/Php70/EregToPcreTransformer.php +++ b/rules/Php70/EregToPcreTransformer.php @@ -132,11 +132,8 @@ private function _ere2pcre(string $content, int $i): array } elseif (in_array($char, ['*', '+', '?'], true)) { throw new InvalidEregException('unescaped metacharacter "' . $char . '"'); } elseif ($char === '{') { - if ($i + 1 < $l && \str_contains('0123456789', $content[$i + 1])) { - $r[$rr] .= '\{'; - } else { - throw new InvalidEregException('unescaped metacharacter "' . $char . '"'); - } + // a "{" in atom position is a literal, e.g. "{[0-9]*}" + $r[$rr] .= '\{'; } elseif ($char === '.') { $r[$rr] .= $char; } elseif ($char === '^' || $char === '$') {