From 5ec010e8194bb0bacfa6b2725f72b24de4cfb889 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 17 Nov 2026 16:22:35 +0100 Subject: [PATCH] [Renaming] Deprecate RenameStringRector, replaced by dedicated rule --- .../Fixture/some_class.php.inc | 27 -------------- .../RenameStringRectorTest.php | 28 -------------- .../config/configured_rule.php | 13 ------- .../Rector/String_/RenameStringRector.php | 37 ++++--------------- 4 files changed, 8 insertions(+), 97 deletions(-) delete mode 100644 rules-tests/Renaming/Rector/String_/RenameStringRector/Fixture/some_class.php.inc delete mode 100644 rules-tests/Renaming/Rector/String_/RenameStringRector/RenameStringRectorTest.php delete mode 100644 rules-tests/Renaming/Rector/String_/RenameStringRector/config/configured_rule.php diff --git a/rules-tests/Renaming/Rector/String_/RenameStringRector/Fixture/some_class.php.inc b/rules-tests/Renaming/Rector/String_/RenameStringRector/Fixture/some_class.php.inc deleted file mode 100644 index defce56920e..00000000000 --- a/rules-tests/Renaming/Rector/String_/RenameStringRector/Fixture/some_class.php.inc +++ /dev/null @@ -1,27 +0,0 @@ - ------ - diff --git a/rules-tests/Renaming/Rector/String_/RenameStringRector/RenameStringRectorTest.php b/rules-tests/Renaming/Rector/String_/RenameStringRector/RenameStringRectorTest.php deleted file mode 100644 index fd306d3a639..00000000000 --- a/rules-tests/Renaming/Rector/String_/RenameStringRector/RenameStringRectorTest.php +++ /dev/null @@ -1,28 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/configured_rule.php'; - } -} diff --git a/rules-tests/Renaming/Rector/String_/RenameStringRector/config/configured_rule.php b/rules-tests/Renaming/Rector/String_/RenameStringRector/config/configured_rule.php deleted file mode 100644 index 25606c1a791..00000000000 --- a/rules-tests/Renaming/Rector/String_/RenameStringRector/config/configured_rule.php +++ /dev/null @@ -1,13 +0,0 @@ -ruleWithConfiguration(RenameStringRector::class, [ - 'ROLE_PREVIOUS_ADMIN' => 'IS_IMPERSONATOR', - ]); -}; diff --git a/rules/Renaming/Rector/String_/RenameStringRector.php b/rules/Renaming/Rector/String_/RenameStringRector.php index c8f5b65b9a3..7613eb49ae8 100644 --- a/rules/Renaming/Rector/String_/RenameStringRector.php +++ b/rules/Renaming/Rector/String_/RenameStringRector.php @@ -6,28 +6,18 @@ use PhpParser\Node; use PhpParser\Node\Scalar\String_; +use Rector\Configuration\Deprecation\Contract\DeprecatedInterface; use Rector\Contract\Rector\ConfigurableRectorInterface; -use Rector\PhpParser\Node\Value\ValueResolver; +use Rector\Exception\ShouldNotHappenException; use Rector\Rector\AbstractRector; use Rector\RuleDoc\CodeSample\ConfiguredCodeSample; use Rector\RuleDoc\RuleDefinition; -use Webmozart\Assert\Assert; /** - * @see \Rector\Tests\Renaming\Rector\String_\RenameStringRector\RenameStringRectorTest + * @deprecated This rule is deprecated, as it renames every matching string literal blindly and was only used for 1 case now covered by dedicated PreviousAdminRoleToIsImpersonatorRector in rector-symfony. Write a custom rule for the exact project case instead. */ -final class RenameStringRector extends AbstractRector implements ConfigurableRectorInterface +final class RenameStringRector extends AbstractRector implements ConfigurableRectorInterface, DeprecatedInterface { - /** - * @var array - */ - private array $stringChanges = []; - - public function __construct( - private readonly ValueResolver $valueResolver - ) { - } - public function getRuleDefinition(): RuleDefinition { return new RuleDefinition('Change string value', [ @@ -72,17 +62,10 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?Node { - $value = $this->valueResolver->getValue($node); - if (! is_string($value)) { - return null; - } - - $newValue = $this->stringChanges[$value] ?? null; - if ($newValue === null) { - return null; - } - - return new String_($newValue); + throw new ShouldNotHappenException(sprintf( + '"%s" rule is deprecated, as it renames every matching string literal blindly; write a custom rule for the exact project case instead', + self::class + )); } /** @@ -90,9 +73,5 @@ public function refactor(Node $node): ?Node */ public function configure(array $configuration): void { - Assert::allString(array_keys($configuration)); - Assert::allString($configuration); - - $this->stringChanges = $configuration; } }