From 1b28071ad52c13febf45ec9cc3e80348e09be2e8 Mon Sep 17 00:00:00 2001 From: jvsena42 Date: Tue, 3 Nov 2026 11:18:27 -0300 Subject: [PATCH 1/3] test: expect review screen for bip21 with an amount Co-Authored-By: Claude Opus 5.5 --- test/specs/send.e2e.ts | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/test/specs/send.e2e.ts b/test/specs/send.e2e.ts index 82017a7..1739b85 100644 --- a/test/specs/send.e2e.ts +++ b/test/specs/send.e2e.ts @@ -162,11 +162,18 @@ describe('@send - Send', () => { await typeAddressAndVerifyContinue({ address: unified1 }); } - // verify amount is set correctly + // a payable amount opens the review screen directly await tap('AddressContinue'); - await verifyAmountToSend(10_000); - await elementById('ContinueAmount').waitForEnabled(); + const unified1ReviewAmt = await elementByIdWithin('ReviewAmount-primary', 'MoneyText'); + await unified1ReviewAmt.waitForDisplayed(); + await expect(unified1ReviewAmt).toHaveText('10 000'); await tap('NavigationBack'); + if (driver.isAndroid) { + // Android replaces the review screen with Amount, so the amount can still be edited + await verifyAmountToSend(10_000); + await elementById('ContinueAmount').waitForEnabled(); + await tap('NavigationBack'); + } // check validation for unified invoice when balance is too low (200_000 sats) const unified2 = 'bitcoin:bcrt1q07x3wl76zdxvdsz3qzzkvxrjg3n6t4tz2vnsx8?amount=0.002'; @@ -360,10 +367,7 @@ describe('@send - Send', () => { console.info({ unified2 }); await sleep(1000); await enterAddress(unified2, { acceptCameraPermission: false }); - // should only allow spending from savings - await elementById('AssetButton-savings').waitForDisplayed(); - await sleep(500); - await tap('ContinueAmount'); + // lightning cannot pay it, so the onchain amount opens the review screen directly await reviewAmt.waitForDisplayed(); await expect(reviewAmt).toHaveText('20 000'); await dragOnElement('GRAB', 'right', 0.95); From 218632a987bce77da8f0e8216ebb6b5129ab7675 Mon Sep 17 00:00:00 2001 From: jvsena42 Date: Wed, 4 Nov 2026 16:15:58 -0300 Subject: [PATCH 2/3] test: expect back to leave a fixed scanned amount on review Co-Authored-By: Claude Opus 5.5 --- test/specs/send.e2e.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/specs/send.e2e.ts b/test/specs/send.e2e.ts index 1739b85..bcc9da5 100644 --- a/test/specs/send.e2e.ts +++ b/test/specs/send.e2e.ts @@ -167,13 +167,8 @@ describe('@send - Send', () => { const unified1ReviewAmt = await elementByIdWithin('ReviewAmount-primary', 'MoneyText'); await unified1ReviewAmt.waitForDisplayed(); await expect(unified1ReviewAmt).toHaveText('10 000'); + // the scanned amount is fixed, so Back returns to the address screen await tap('NavigationBack'); - if (driver.isAndroid) { - // Android replaces the review screen with Amount, so the amount can still be edited - await verifyAmountToSend(10_000); - await elementById('ContinueAmount').waitForEnabled(); - await tap('NavigationBack'); - } // check validation for unified invoice when balance is too low (200_000 sats) const unified2 = 'bitcoin:bcrt1q07x3wl76zdxvdsz3qzzkvxrjg3n6t4tz2vnsx8?amount=0.002'; From 5ff666681897d886b3143070858a73e8677df9b9 Mon Sep 17 00:00:00 2001 From: jvsena42 Date: Wed, 4 Nov 2026 16:16:18 -0300 Subject: [PATCH 3/3] test: drop the unused amount check import Co-Authored-By: Claude Opus 5.5 --- test/specs/send.e2e.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/test/specs/send.e2e.ts b/test/specs/send.e2e.ts index bcc9da5..d50e41f 100644 --- a/test/specs/send.e2e.ts +++ b/test/specs/send.e2e.ts @@ -27,7 +27,6 @@ import { tap, selectSendFundingSource, enterAmount, - verifyAmountToSend, } from '../helpers/actions'; import { lndConfig } from '../helpers/constants'; import { reinstallApp } from '../helpers/setup';