From 787b5bad1a389c653f0f59aabaec772b2cb0206d Mon Sep 17 00:00:00 2001 From: Colleen Murphy Date: Tue, 10 Nov 2026 23:07:51 +0000 Subject: [PATCH] Use public key for ed25519 Signer verify method Without this patch, the .verify function field in note.Signer uses the Signer's private key to verify a signature, which means the Verifier method returns an unusable verifier. This change fixes the callback to use the correct key. Found and fixed by AI, reviewed by me. Signed-off-by: Colleen Murphy --- note/note.go | 2 +- note/note_test.go | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/note/note.go b/note/note.go index c331abf..223fb68 100644 --- a/note/note.go +++ b/note/note.go @@ -89,7 +89,7 @@ func NewSigner(skey string) (Signer, error) { return ed25519.Sign(key, msg), nil } s.verify = func(msg, sig []byte) bool { - return ed25519.Verify(key, msg, sig) + return ed25519.Verify(pubkey[1:], msg, sig) } return s, nil diff --git a/note/note_test.go b/note/note_test.go index bf267f3..6a3c807 100644 --- a/note/note_test.go +++ b/note/note_test.go @@ -41,7 +41,9 @@ func TestSignerVerifier(t *testing.T) { t.Fatalf("NewVerifier: %v", err) } root := sha256.Sum256([]byte("blah")) - checkRoundTrip(t, fmt.Sprintf("%s\n0\n%s\n", test.name, base64.StdEncoding.EncodeToString(root[:])), ns, nv) + msg := fmt.Sprintf("%s\n0\n%s\n", test.name, base64.StdEncoding.EncodeToString(root[:])) + checkRoundTrip(t, msg, ns, nv) + checkRoundTrip(t, msg, ns, ns.Verifier()) }) } }