From 3ccc6ddffa2a3ea1cbcfec96deb4d11065e31048 Mon Sep 17 00:00:00 2001 From: Egor Gruzdev Date: Mon, 2 Nov 2026 21:39:35 +0200 Subject: [PATCH] Clamp operator counter decrements at zero bound_tickets and total_complexity are unsigned; a drifted counter made decrement() throw SQLSTATE 22003 on ticket close/unbind, which aborted projection and left the closed ticket bound to the operator. --- src/Domain/Operator/Projections/Operator.php | 23 +++++++++++++++++++ .../Operator/Projectors/OperatorProjector.php | 12 +++++----- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/src/Domain/Operator/Projections/Operator.php b/src/Domain/Operator/Projections/Operator.php index 735e020d..4bbaeee6 100644 --- a/src/Domain/Operator/Projections/Operator.php +++ b/src/Domain/Operator/Projections/Operator.php @@ -11,6 +11,7 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo; use Illuminate\Database\Eloquent\Relations\BelongsToMany; use Illuminate\Database\Eloquent\Relations\HasMany; +use Illuminate\Database\Query\Expression; use Spatie\EventSourcing\Projections\Projection; use TTBooking\TicketAllocator\Domain\Ticket\Projections\Ticket; use TTBooking\TicketAllocator\Models\OperatorTeam; @@ -82,6 +83,28 @@ protected function name(): Attribute return Attribute::get(fn ($value) => $value ?? $this->user->name); } + /** + * Not decrement(): `col - n` on an unsigned zero fails before any GREATEST() around it. + */ + public function decrementToZero(string $column, int $amount = 1): int|false + { + $this->{$column} = max(0, $this->{$column} - $amount); + + if ($this->fireModelEvent('updating') === false) { + return false; + } + + $wrapped = $this->getConnection()->getQueryGrammar()->wrap($column); + + return tap($this->setKeysForSaveQuery($this->newQueryWithoutScopes())->update([ + $column => new Expression("GREATEST($wrapped, $amount) - $amount"), + ]), function () use ($column) { + $this->syncChanges(); + $this->fireModelEvent('updated', false); + $this->syncOriginalAttributes($column); + }); + } + /** * @return BelongsTo */ diff --git a/src/Domain/Operator/Projectors/OperatorProjector.php b/src/Domain/Operator/Projectors/OperatorProjector.php index 2627ee60..18764af1 100644 --- a/src/Domain/Operator/Projectors/OperatorProjector.php +++ b/src/Domain/Operator/Projectors/OperatorProjector.php @@ -104,8 +104,8 @@ public function onTicketBound(TicketEvents\TicketBound $event): void } $operator = $ticket->operator?->writeable(); - $operator?->decrement('bound_tickets'); - $operator?->decrement('total_complexity', $ticket->complexity); + $operator?->decrementToZero('bound_tickets'); + $operator?->decrementToZero('total_complexity', $ticket->complexity); $newOperator->increment('bound_tickets'); $newOperator->increment('total_complexity', $ticket->complexity); @@ -130,8 +130,8 @@ public function onTicketUnbound(TicketEvents\TicketUnbound $event): void return; } - $operator->decrement('bound_tickets'); - $operator->decrement('total_complexity', $ticket->complexity); + $operator->decrementToZero('bound_tickets'); + $operator->decrementToZero('total_complexity', $ticket->complexity); } public function onTicketClosed(TicketEvents\TicketClosed $event): void @@ -141,7 +141,7 @@ public function onTicketClosed(TicketEvents\TicketClosed $event): void return; } - $operator->decrement('bound_tickets'); - $operator->decrement('total_complexity', $ticket->complexity); + $operator->decrementToZero('bound_tickets'); + $operator->decrementToZero('total_complexity', $ticket->complexity); } }