Repository navigation
fix(core): constrain CP-06 context and worker recovery - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Resume and ship the already authorized Factory CP-06 A1/C1 correction on top of the unchanged audited PR11 head while retaining PR8/PR9/PR10/PR11 ancestry and preserving all unrelated work. A1 must make the actual Pi 0.85.1 SDK worker require a structured creation-time integration evidence finding: reject absent, empty, duplicate, wrong, or contradictory evidence gaps; preserve canonical source identity, explicit fixture-origin versus semantic-acceptance distinction, exactly one complete original built-in read with no offset or limit, and executable actual-SDK DUMMY negative and valid-positive coverage. C1 must propagate exit status only after awaited cleanup in the runner and namespace supervisor, retain both primary and cleanup failures, and cover expired, near-expiry, setup, launch, timeout, audit, cleanup, and compound failures. Preserve PR11's public injected read-only credential store that denies mutation callbacks before refresh/persistence and its capability-free, no-new-privileges, securebits-locked, seccomp-isolated Linux x86-64 child; every destructive auth probe must remain DUMMY-only, with no real credential inspection, copying, export, mutation, remount, refresh, or fixture stream promoted as genuine semantic evidence. Preserve source-scope and provenance behavior, STANDARD offline semantic ten-pack evidence of 10/10 relevant with zero irrelevant, and P-07; disclose that strict-agent retrieval is separately PARTIAL/CONFLICTING rather than COMPLETE and do not widen filters to hide omissions. A genuine fresh semantic worker remains blocked/not verified unless both DUMMY protections and adequate non-refresh credential validity are safely preflighted. Validate the exact final SHA with install, format, lint, typecheck, full tests, DUMMY S1/S2 and A1/C1 proofs, STANDARD ten-pack, P-07, manifests, hashes, and diff/ancestry checks. Make no Firstmate routing, global credential/config/model, external-tool, merge, deployment, or release change. Open a new PR only; green CI does not complete CP-06, and a separate independent exact-head critical security/acceptance audit is still required before any conditional captain merge.
What Changed
context.requireddocuments, falling back to mandatory project documents, with provenance checks that reject excerpts outside the selected retrieval scope.Risk Assessment
Testing
Verified exact target SHA 6b9b6e2, installed dependencies, ran focused A1/C1 behavioral tests for worker audit/outcome/lifecycle and credential isolation, then produced end-to-end CP-06 proof artifacts for the fresh SDK worker, cleanup failure propagation, auth security, STANDARD ten-pack, and P-07; the first worker proof attempt failed before its ten-pack fixture prerequisite existed, and the same proof passed after generating ten-pack evidence.
Evidence: Focused CP-06 behavioral test transcript
Evidence: Fresh SDK worker proof transcript
Evidence: Fresh SDK worker evidence manifest
/home/ansh/.treehouse/Factory-86709f/13/Factory/.factory/state/n/h/.no-mistakes/evidence/01M3VRTZ4TD8H2RVDX7FCHS6D2/cp06-ten-pack-evidence.json)Evidence: P-07 evidence manifest
Evidence: Auth security evidence manifest
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
scripts/cp06-worker-audit.mjs:9- Intent requires preserving canonical source identity, and the prior user-selected fix requiredmissing_sourceto be exactlydocs/AUTH.md, but this resolver check still accepts any equivalent path. WithreferenceRootset to the fixture root,./docs/AUTH.mdpasses; an absolute fixture path also passes becausepath.resolve(referenceRoot, absolutePath)returns the absolute path. Compare the reported value exactly todocs/AUTH.mdat the outcome boundary and add the requested negative cases.🔧 Fix: Enforce canonical missing source identity
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
git status --short && git rev-parse HEAD && lsnpm cinode --test test/cp06-worker-audit.test.mjs test/cp06-worker-outcome.test.mjs test/cp06-worker-lifecycle.test.mjs test/cp06-readonly-credentials.test.mjs test/cp06-credential-isolation.test.mjsnpm run proof:cp06:workerinitial attempt before ten-pack generation, then rerun after ten-pack generationnpm run proof:cp06:worker-cleanupnpm run proof:cp06:auth-securitynpm run proof:cp06:ten-packnpm run proof:cp06:p07✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.