Repository navigation
Conversation
|
Hey @theobiabo, first, an apology. You asked to take this issue, I said yes, and then after you'd put in all this work I changed the design under you. That's on me, not you. I should have told you on the issue as soon as I started rethinking hooks. The work itself is really good. The report is unusually honest about where it falls short: the performance gate, the render isolation limits, what wasn't measured. That's exactly what I wanted from #27. What changed: while reviewing the design I realised hooks fight GPUI's model, so #27 now uses signals instead. They're
Your finding that equal props can't skip rendering without If you're still up for it, I'd love for you to keep going on the signals version. If you'd rather not after this, that's completely understandable, and thank you either way. Happy to answer any design questions on the issue. |
|
Sure I'm still up. |
|
hey @theobiabo any updates? |
|
Yooo, @1bye will raise a PR, I migrated the configs to a more better PC, should do that before EOD. |
|
@theobiabo that's cool, ty! |
|
Sure bro. |
|
Yo @1bye, please, you can confirm the PR now; all stated changes have been updated. |
|
@theobiabo awesome! Let CI run and I will review it, and merge |
|
Sure one chief. |
|
@theobiabo I reviewed the implementation against #27 and reran the feature suites: 262 tests passed. The core signals implementation is in place, but a few things need resolving before merging:
The unrelated CI installation issue and unused-parameter failures are being handled separately. |
|
Sure I'm gonna fix that. |
|
@1bye The issue has been fixed. |
|
Hey @1bye Let me know if there are any issues, would be on the standby. |
|
@theobiabo yep, here it is |
|
@theobiabo Before merging, please complete the remaining #27 requirements within Rake, using the existing pinned GPUI unchanged:
We reran the full benchmark suite three times. All correctness and disposal assertions passed, but the measured performance overhead remains above the target. Please profile and optimize the Rake-side implementation, then rerun the benchmark matrix and commit the results. Keep correctness, state identity, borrowed reads, and cleanup guarantees covered. If the performance target proves unreachable under the unchanged-GPUI constraint, bring back measurements explaining the limitation before proposing a scope change. |
|
@theobiabo I have fixed CI problems and tiny other things |
|
Okay, that sounds great, will make this updates. I'm open to picking on other issues too. |
Summary
Added an opt-in function component API for #27, allowing components to use persistent state and lifecycle hooks while keeping Rake’s existing
view!syntax.The implementation is behind
experimental-components. It remains experimental because render isolation and performance acceptance are unresolved.Implementation
Component API
#[rake::component]to generate props and a retained GPUI view.<Counter ... />and{..defaults}syntax.PartialEqrequired only for#[rake::component(memo)].State and lifecycle
Scope,use_state,use_ref,use_memo, anduse_effect.Integrations