Skip to content

Accept external file drops in Rake views - #90

Merged
1bye merged 8 commits into
mainfrom
codex/file-drop-85
Nov 16, 2026
Merged

1bye merged 8 commits into
mainfrom
codex/file-drop-85

Conversation

@1bye

@1bye 1bye commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Closes #85

The files example imports one externally dropped file through the same bounded FileHandle reads as its picker, preserving busy and unsaved-change guards. Native views use ExternalPaths; Web uses real browser File handles from canvas DOM drops and ignores non-file drags. Add the theme-aware drag-over: class variant, accessible target labels, and documentation in docs/view.md and docs/platform-services.md.

Validation:

  • Local native and Wasm library checks passed.
  • Local simulated GPUI drop dispatch and drag-over Entered/Pending/Exited/Submit style tests passed, including after merging main.
  • All 26 class compiler unit tests and 2 consumer tests passed locally.
  • JavaScript file identity, read/count bounds, disposal and non-file drag checks passed locally.
  • Rake formatting and lint passed.
  • At e322a2c, CI passed gate, portable, desktop Ubuntu, desktop Windows, windows-features, native, web-e2e and spacing. The optional extended job was skipped by workflow configuration.

Windows desktop CI has a 90-minute budget because the 60-minute run timed out during passing workspace tests; all test and lint steps remain enabled.

Real file-manager drag gestures were not exercised locally. Windows/Linux runtime and browser host validation relied on CI. Web drop targets cover the whole canvas.

🤖 Generated with Claude Code

1bye and others added 8 commits November 15, 2026 18:07
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows job reached its 60-minute limit during passing workspace tests after the development profile update. Allow 90 minutes for this matrix entry while retaining every test and lint step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@1bye
1bye marked this pull request as ready for review November 16, 2026 10:54
@1bye
1bye merged commit c91c839 into main Nov 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop files from the OS onto a view

1 participant