Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add UTC timestamps, target, messages and fields to bounded 4 KiB log records. Share the formatted line with ctl, redact secret-named fields, escape values and mark UTF-8-safe truncation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace raw framework error payloads with static error types. Omit tray diagnostic bodies, document AST/text dumps, URL strings, response-header values and browser clipboard exception details from runtime logging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Web delivery returns fixed categories rather than sink payloads. Preserve the warning error field consumed by the unchanged browser regression test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
App logging uses the existing tracing subscriber, private platform log directories, bounded output worker and ctl transport. Release files rotate at 1 MiB with three archives and a 4 MiB total budget; development stderr keeps its existing format, and Web keeps console output. Disk failures discard output without stopping the app.
File records now include an RFC 3339 UTC timestamp, level, target, application message and event/span fields. Secret-looking field names are matched by case-insensitive substring and their values become
[redacted]: password, passwd, secret, token, authorization, cookie, api_key/apikey, credential, private_key and session. Values escape newlines. Each record is bounded to 4 KiB including its newline, with UTF-8-safe…[truncated]marking.rake ctl logsretains the same formatted line with its sequence cursor and loss counters. A separate bounded tail keeps up to 128 entries within a 256 KiB encoded budget, leaving room in the transport frame. File and ctl retention can lose different subsets under contention, overflow or disk failure, but retained lines have identical content. Crash records keep their structural-only diagnostic tail and optional log path.Runtime privacy audit changes:
error_typemetadata instead of formatting error payloads that could include paths, URLs or application text.Applications retain responsibility for secrets or personal data inside messages, targets, unrecognized fields and free-form debug/error values. Key redaction is a heuristic. docs/logging.md describes that boundary, Rake's own privacy rules, timestamps, truncation, paths, configuration, bounds and ctl behavior.
Web crash delivery retains its fixed, privacy-safe
errorcategory for the unchanged browser regression test; sink error payloads remain omitted.CI note: Windows desktop hit the known cold-cache 60-minute timeout on f0bd797 and 3de2938, also present on main. On 3de2938, the real desktop dev/CDP, GUI inspection, reload, shutdown and editor-process survival smoke checks passed before cancellation during later tests. Workflow timeouts are unchanged in this PR. Ubuntu had one existing source-opener fixture launch failure; all 14 broker tests pass locally. Its rerun is blocked until the still-active native job completes.
Local validation: 70 headless rake-app unit tests plus the native local_control transport test; 11 diagnostics unit tests, two snapshot tests and one doctest; strict diagnostics Clippy; native App Clippy; default Web App Clippy; rake format and rake lint. Coverage includes secret-key matching/case, newline escaping, timestamp format, 4 KiB UTF-8 truncation, file message/target content, file/ctl equality, concurrent writes, loss counters, rotation/bounds, failed setup/writes and unchanged development stderr formatting. CI is pending for the new head. Workflow timeouts are unchanged.
🤖 Generated with Claude Code