Repository navigation
Conversation
Reuse host-default artifacts for implicit native compatibility builds, retain explicit target selection, and preserve the desktop check name across parallel jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cold Windows desktop job reached its 60-minute limit while saving dependencies. Split it into
windows-smoke(private endpoints, supervisor, default lints, smoke, inspection and GUI) andwindows-tests(workspace and both view suites), with separate cache shared-keys and 60-minute timeouts. All test commands, assertions and per-step timeouts remain. Linux's matrix entry and commands are unchanged.desktop (windows-latest)remains as an aggregate that fails unless both jobs succeed; the protection API returned 404Branch not protected, so configured required checks could not be verified there.The explicit-target fixture is consumed by
windows-inspection-smoke.py's warmbundle --native --compatand byrake devthroughProject::build→ distribution →execution::build. Inspection/ctl/CDP consume the staged artifact, not a triple-specific path. Preserve whether--target-triplewas explicitly requested; implicit native compatibility builds now use Cargo's host-default graph. Explicit target requests, standalone bundles and universal slices retain target selection. Remove the duplicate explicit-target prebuild from the Windows job. Added smoke assertions that both warm packaging and real dev avoid recreating that artifact; all existing GUI, CDP, reload, shutdown and editor Job-survival assertions remain.Validation: Ruby/Psych YAML parsing and
git diff --checkpassed.rake formatandrake lintpassed with the installed binary (777 Rust files, 0 diagnostics). A parsed-workflow self-check confirms the Linux steps are byte-for-byte equivalent as YAML, the moved Windows commands/conditions/per-step timeouts are preserved, all Windows job limits are 60, and the new cache shared-keys differ. Python AST parsing passed; no local Cargo builds. The two new jobs use a freshv3-rake-ci-windows-splitprefix, so their first PR run is cold. PR dependency cache saving remains disabled (save-ifis main-only). A second run and measured timings will be added before this draft is ready.Measured baseline supplied from main run 43750399881: approximately 58 minutes of steps, then cancelled saving cache at 60 minutes. Main reference run 43853082547 at c91c839 is still running; its final step times and actual cache-save result are pending observation.
🤖 Generated with Claude Code