Repository navigation
feat(desktop): 按 macOS 基线对齐 Viva 工作台与设置界面 - #1849
Merged
Merged
Conversation
1lck
marked this pull request as ready for review
November 13, 2026 09:20
Lithe Review结论: 未发现需要阻塞合并的问题。建议补齐界面前后对照证据;本次未确认代码缺陷。 Scope Check
架构归属对账
其余上游领域能力审查不适用:本次未扩展语言服务、构建、运行或调试机制。 Checked and cleared
Suggestions
Observations
Summary静态检查未发现明确的正确性或架构回归。菜单与设置改动复用现有入口,相关行为测试保留了关键断言;视觉对齐及两端原生体验仍需运行证据确认。 Verification
|
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue / Linked issue
PR 类型 / Type
改动说明 / What changes
背景 / Why
Viva 重构后的工作台与设置窗口仍沿用部分框架默认外观,与用户提供的
main-macos-live-baseline.zip(原客户端提交a824bd5c)存在明显差异。本 PR 按这份已有截图校准当前已实现的页面;未启动旧 main 客户端,也未扩展工作量较大的缺失子系统。改动 / Changes
{26 27 28}、修复后保持面板色#191a1c;补充既有架构 Note 的绘制顺序约束。vivahead lithevisual),隔离 store、fixture 仓库、插件事实与日志,真实点击弹层入口并断言已绘制;补布局/菜单行为与像素回归。调整原有 Git/拖动测试显式打开其依赖的底部面板,保留原断言。LITHE_VISUAL_LANGUAGE=en,中英文均覆盖深浅色。不在本 PR 范围内 / Out of scope
类型专属:feat
多平台对齐
范围检查 / Scope checks
功能矩阵 / Feature matrix
verify-platform-feature-matrix-change.sh origin/preview HEAD门禁。.artifacts/生成视图。统一日志系统 / Structured logging
N/A:仅调整呈现与既有操作入口,未新增操作终态、失败、降级或恢复路径;行为继续调用原有带日志的处理函数,未新增日志事件或豁免。
界面文案 / i18n
shared/i18n/,生成文件由生成器更新;未在产品代码硬编码文案。逻辑归属 / Logic placement
性能与内存 / Performance and memory
设置 / Settings
插件契约 / Plugin contract
N/A:未改 Core pin、插件协议、SDK、宿主方法或通知。
发行包与资源 / Bundle and resources
N/A:没有新增运行时资源、下载、解压或缓存路径;docs/assets 中仅是离线审阅截图。仍已运行 desktop macOS / Windows 资源只读静态门禁。
无用代码与重构 / Dead code and refactoring
验证 / Verification
scripts/desktop/desktop-go.sh test ./... -count=1 -timeout=180sscripts/desktop/desktop-go.sh vet ./...、vet -tags dev ./...、test -tags dev ./internal/buildinfo -count=1scripts/desktop/desktop-go.sh --exec go run github.com/vivaui/viva/cmd/viva vet ./...LITHE_VISUAL_OUTPUT_DIR=<output> LITHE_VISUAL_BASELINE_DIR=<extracted-baseline> scripts/desktop/desktop-go.sh test -tags 'vivahead lithevisual' ./internal/workbench ./internal/settingswindow ./internal/logwindow -run '^TestVisual' -count=1 -timeout=180sLITHE_VISUAL_OUTPUT_DIR=<output> LITHE_VISUAL_LANGUAGE=en scripts/desktop/desktop-go.sh test -tags 'vivahead lithevisual' ./internal/settingswindow -run '^TestVisualSettings$' -count=1 -timeout=60s.agents/skills/write-stable-tests/scripts/run-go-tests-with-timing.mjs(macos-ui-full / pixel / changed / capture / english / pr-final)node scripts/i18n/verify-app-language-localization.mjs、node scripts/i18n/generate-i18n.mjs --check、node --test --test-timeout=60000 scripts/i18n/test-i18n.mjsscripts/platform-feature-matrix/verify-platform-feature-matrix.sh、verify-platform-feature-matrix-change.sh origin/preview HEADscripts/desktop/verify/verify-runtime-bundle-immutability.sh、scripts/agent-notes/verify-agent-notes.sh.agents/skills/write-stable-tests/scripts/verify-test-stability.sh --base origin/preview --platform macos、git diff --check、gofmtCI 结果补充: macOS 与 Linux 完整 lane、格式/脚本、依赖固定、功能矩阵和 Agent Note 检查均通过。Windows 在链接阶段失败:
cannot find -lwinapi_advapi32 / -lwinapi_cfgmgr32 / -lwinapi_kernel32 / -lwinapi_user32,没有进入相关界面测试。同一故障已存在于 PR 基线549696fdb,不是本次新增:仓库保护仍要求已移除的
macOS CI gate检查名及代码评审;按维护者本次明确要求合入 preview,使用仓库已有的 PR 合并豁免权限,不修改保护规则或伪造成功状态。本 PR 未改 Core pin、构建脚本或 Windows 链接参数;该能力仍由 #1798 跟踪,不把失败记为通过。等待 CI 时 preview 合入 #1848 (
a6f68e7de),已在本地临时合并两份改动、运行设置模块全量测试,通过(3.255s),随后撤销临时合并;没有为重复触发 CI 而推送无实质变化的提交。未能执行的检查和原因: 未在 Windows 运行原生验收;macOS 原生启动及用户查看不代表所有页面与真实工具链/插件流程已验收。全仓稳定性扫描会扫描用户已有未跟踪 extension-host/node_modules 的第三方计时器测试,未将该目录提交或改豁免;本次改动的 macOS 增量门禁通过。测试时有既有 Core dead-code 和本机 SDK 链接警告,本 PR 未改工具链或 Core。
离线截图:中英文与深浅色
提交前确认 / Final checks
549696fdb创建;推送前重新 fetch,远端未前进;目标 preview。