Repository navigation
fix(java): stabilize Viva project tools and validate plugin workflows - #1884
Merged
Merged
Conversation
1lck
marked this pull request as ready for review
November 13, 2026 22:42
Lithe Review结论: 未发现需要阻塞合并的问题。发现一项 P2 工具启动边界遗漏。 Findings
Scope Check
架构归属对账
Checked and cleared
Suggestions
Observations
Summary主要接线方向符合现有架构,回归覆盖明显增加。建议补齐随包工具的固定安装解析,避免同一种工具在后端启动与调试适配器启动时获得不同的安装事实。 Verification
|
2 tasks done
15 tasks done
Lithe 运行验收版本: 执行未完成:Invalid scenario identity 本次未形成完整验收结果,详见执行原因。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue / Linked issue
PR 类型 / Type
改动说明 / What changes
背景 / Why
当前 Viva 的插件启动桥接遗漏了已选择的项目 JDK 与 Core 归一后的工具入口。普通 Java 8 源码可能被 JDT 按 Java 21 编译后无法运行;Gradle CLI 编译虽然成功,导入设置后端却没有真正启动。修复通用接线,并用真实插件、构建工具、语言服务器和调试器验证全链路,Java 专属规则继续留在插件。
改动 / Changes
前置测试修复:PR #1886。首次远端 CI 的 Linux/Windows 都只失败在既有关闭标签测试(同 preview 基线文件);独立分支复现并修复遗漏的刷新,正式新回归在修复前为红、修复后为绿,不靠重跑或扩大超时。本分支包含同一修复;前置 PR 单独维护其红绿回归、矩阵和 Note,产品快捷键逻辑不变。
配套 PR:Core #29、Java #9、Gradle #10。Maven 使用现有 v0.0.1 prerelease,不需要新增后端改动。
不在本 PR 范围内 / Out of scope
没有发布 tag/Release/市场条目,也没有改 JDT 1.61 / Temurin 21 / Parallel GC 生产资源参数。不是任意 Java 项目支持完成的声明:JavaCC 生成源码模型 #1881、多版本 JAR #1882、jOOL 的 javac/ECJ 泛型差异 #1883 仍未完整跑通。Java 5/7 源码级别被当前 ECJ 安全拒绝;Ant 源码布局不代表执行 Ant target;JSP HTTP 与 Servlet 断点不代表 JSP 源码补全或 JSP 断点。长 module-path 见 Java 插件 #7。
类型专属:fix
复现与根因
检查项
范围检查 / Scope checks
功能矩阵 / Feature matrix
统一日志系统 / Structured logging
界面文案 / i18n
逻辑归属 / Logic placement
性能与内存 / Performance and memory
设置 / Settings
N/A:没有改设置 UI 或写回行为;配套 Gradle 修复真实 gradle.properties 读取,端到端严格回读验证。
插件契约 / Plugin contract
N/A:没有改协议/schema/fixture/SDK 或新增宿主方法通知;复用 Core 既有工具模板接口。Core pin 仅含通用握手默认期限与回归,其完整 SDK e2e CI 已通过。
发行包与资源 / Bundle and resources
无用代码与重构 / Dead code and refactoring
验证 / Verification
未能执行的检查和原因: 原生 Viva 窗口、正式安装/签名/更新、任意框架与全部日志路径没有完整验收。Windows 为 ARM VM 中 x64 工具,功能可验证,耗时不能代表原生 AMD64 性能。默认全工作区测试静态门禁会扫描用户已有未跟踪 extension-host/node_modules;没有删除或豁免该目录,PR 提交差异门禁通过。旧日志/边界检查已移除的部分保持未完成,不将组件测试当整机 UI 验收。
提交前确认 / Final checks