Repository navigation
feat(desktop): Core 固定版本升到 Lithe-core-rust#33,构建检测跳过被 Git 忽略的目录 - #1898
Merged
Merged
Conversation
PINNED_CORE_REVISION 升到 Lithe-core-rust#33 的合并提交 29b35bf。build.detect 和自动运行项发现按工作区内的 .gitignore 与仓库的 info/exclude 剪掉目录, .claude/worktrees 下的代理工作树、生成目录和本地副本不再被当成构建根目录, Build 窗口不会把同一个模块列两遍。中间还带上 #32(Markdown 内联 SVG 保留白名单 绘图元素)。 功能矩阵 build-system-plugins 的说明补上这条行为。
xiaoyumuxi
marked this pull request as ready for review
November 14, 2026 05:26
Lithe Review结论: ❓ 审查未完成 已由服务器取消。可以重新评论 |
This was referenced Nov 14, 2026
23 of 29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue / Linked issue
PR 类型 / Type
改动说明 / What changes
背景 / Why
Build 窗口会把同一个模块列两遍。原因是
build.detect把被 Git 忽略的目录也当成了构建根目录,例如.claude/worktrees/*下的代理工作树、生成目录和本地副本。Core #33 让检测跳过这些目录,桌面端要把固定的 Core 版本升上去才能用到。改动 / Changes
scripts/desktop/build-desktop-core.sh:PINNED_CORE_REVISION从62b8a08([Windows][W3] 多会话终端系统 #31)升到29b35bf([Feature] 希望能支持 vim 模式 #33 的 squash 合并提交)。build.detect和自动运行项发现共用一个最多 6 层的启发式扫描,现在它会剪掉被 Git 忽略的目录。规则来自工作区内的.gitignore,以及根目录在工作区内的每个仓库的info/exclude;链接工作树经commondir读主仓库共享的info/exclude。不读工作区根以上的目录、core.excludesFile和索引。指纹扫描和 Node 清单发现不变。build-system-plugins的说明补一句检测跳过 Git 忽略的目录,并写上 Core 的测试名。状态保持 partial/pending。不在本 PR 范围内 / Out of scope
displayName契约和 Go 插件的映射:feat(desktop): Build 窗口的目标行只显示路径,悬停显示完整名称 #1895 已经只显示路径,这两项是否还要做,待确认。类型专属:feat
多平台对齐
platform-specific),理由:范围检查 / Scope checks
功能矩阵 / Feature matrix
shared/platform-feature-matrix/features/build-system-plugins.json的说明;状态和验证保持 partial/pending./scripts/platform-feature-matrix/verify-platform-feature-matrix.sh(222 项通过)和./scripts/platform-feature-matrix/verify-platform-feature-matrix-change.sh origin/preview HEAD(通过).artifacts/下生成的矩阵视图统一日志系统 / Structured logging
N/A:桌面端代码没有改动。
界面文案 / i18n
N/A:没有新增或修改界面文案。
逻辑归属 / Logic placement
性能与内存 / Performance and memory
设置 / Settings
N/A:没有改设置。
插件契约 / Plugin contract
detection一行、构建系统参考页)已在 Core [Feature] 希望能支持 vim 模式 #33 里随代码一起提交,同一个 PR 登记了协议更新记录(2026-11-14,API 编号 —,pluginAPIVersion0 内的补充):Lithe-IDEA/Lithe-core-rust#33PINNED_CORE_REVISION已升到29b35bf,桌面端测试经scripts/desktop/desktop-go.sh读到的是这份契约发行包与资源 / Bundle and resources
./scripts/desktop/verify/verify-runtime-bundle-immutability.sh,通过无用代码与重构 / Dead code and refactoring
验证 / Verification
./scripts/desktop/desktop-go.sh test ./... -count=1(在desktop/,链接 Core29b35bf)cargo test -p lithe-core、clippy、fmt、注释和文档校验./scripts/desktop/verify/verify-runtime-bundle-immutability.sh未能执行的检查和原因: 没有在 Windows 实机上运行。没有在打包后的应用里打开带代理工作树的仓库手动核对 Build 窗口,检测结果由 Core 的分发器测试
tests::build_systems::detection_skips_directories_git_ignores覆盖。提交前确认 / Final checks
preview(a7eee36,feat(desktop): Build 窗口可运行的行常驻绿色运行按钮,依赖标题加 ⓘ #1896 之后)创建,目标分支preview