Repository navigation
fix(desktop): 保留虚拟源码语言和 URI,取消过期类导航 - #1906
Merged
Merged
Conversation
16 of 17 tasks
1lck
marked this pull request as ready for review
November 14, 2026 06:48
Lithe Review结论: ❓ 审查未完成 已由服务器取消。可以重新评论 |
22 of 28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue / Linked issue
PR 类型 / Type
改动说明 / What changes
背景 / Why
依赖类的定义返回虚拟 URI 后,Viva 没有赋予文档语言,并再次按磁盘路径转换 URI,导致只读源码不能继续发起正确的语言导航。慢内容响应还可能在用户移动光标后打开标签抢走焦点。Java 插件另行提供既有内容扩展点;本 PR 只修通用呈现接线。
改动 / Changes
不在本 PR 范围内 / Out of scope
JSP 中的 Java 语言服务、直接把零散 class 文件当完整工程、缺失依赖或内部类恢复、内存整体优化、原生窗口验收。功能矩阵继续 partial/pending;单项无头通过不代表全功能验收。既有纯校验归属债务见 #1892。
类型专属:fix
复现与根因
jdt:源码目标;打开后 languageID 为空,再按文件路径转换 URI,第二次导航失效。原始接线来自0faecba491;当前文档同步延续在10385ee0a。obsolete class navigation stole focus,恢复保护后通过。检查项
范围检查 / Scope checks
逻辑归属 / Logic ownership
多平台功能矩阵 / Platform feature matrix
java-support-plugin.json的能力、证据和具体流程;未把整体能力改成 verified。统一日志系统 / Unified logging
plugin_content失败目录事件和统一 i18n 提示;用户取消不报错误并说明豁免。界面文案与 i18n
N/A:没有新增界面文案;既有提示仍用共享 i18n。现有检查通过。
性能与内存 / Performance and memory
设置 / Settings
N/A:没有修改设置。
插件契约 / Plugin contracts
N/A:复用现有内容提供者、函数和语言服务器请求,无新方法、协议、权限或 Core pin 变更。
发行包与资源 / Bundle and resources
无用代码与重构 / Dead code and refactoring
验证 / Verification
scripts/desktop/desktop-go.sh test ./...-race,另真实二进制导航-race--base 04595785b本地私有输入另验证两个残缺依赖类的类型/方法落点和类间导航;首次打开约 1.5/1.8 秒,热方法跳转约 0.1 秒。JDT RSS 约 774→993 MiB,整个无头进程树约 913→1154 MiB;关闭后 JDT 退出。只是单点观测,不能宣称内存下降或峰值。私有源码、class、JSP、反编译内容、URI/日志未提交。
最新 preview 合并后,自建无源码 JAR 全链路再次通过(18.05 秒);最终发布资产另作实际包检查。
未能执行的检查和原因: 原生窗口和完整日志界面验收未覆盖;日志生成/使用门禁缺失见 #1802。JSP 仍为 HTML,不把 Servlet/JSP HTTP 验证当源码支持。
提交前确认 / Final checks
04595785b创建,目标 preview。发布前最终核验
macOS CI gatecontext,当前 Desktop CI 已改为 Vet and test on macOS;不修改仓库保护规则。根据用户预先授权,以管理员压缩合并,明确保留未完成 CI 状态;本地两端实际工作流及 macOS 全量/竞态检查已通过。