Repository navigation
fix(tests): 终端菜单测试通过真实侧栏交互触发重绘 [skip ci] - #1917
Merged
Merged
Conversation
1lck
marked this pull request as ready for review
November 14, 2026 10:33
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue / Linked issue
PR 类型 / Type
改动说明 / What changes
背景 / Why
终端菜单测试直接改变工具窗口状态后,只调用消费已有重绘请求的 Pump;没有待处理的后台请求时,终端内容不会绘制,测试报
the terminal is not shown。终端输出偶尔提供一帧,因而掩盖缺少刷新,导致同一用例时过时败。改动 / Changes
不在本 PR 范围内 / Out of scope
无产品界面、Core、Viva 或插件协议改动。#1908 的同步 gofmt 管道挂起已由 #1911 改成临时文件、异步调用及超时,本次只核对已有修复,完整 i18n 测试 41/41 通过。
类型专属:fix
复现与根因
context_menu_test.go:63: the terminal is not shown;期望打开面板后可操作菜单。改为真实按钮点击后连续 20 次通过。检查项
范围检查 / Scope checks
功能矩阵 / Feature matrix
插件归属 / Plugin ownership
统一日志系统 / Structured logging
N/A:仅修复测试驱动方式,无生产生命周期、终态或错误路径变化。
界面文案 / i18n
N/A:没有用户可见文案变更。共享语言检查和生成一致性检查已运行并通过。
逻辑归属 / Logic placement
N/A:没有新增或修改业务逻辑、Core 规则或平台适配器。
性能与内存 / Performance and memory
N/A:不修改生产性能路径,不新增运行时、缓存、定时器或依赖;测试保留原有有界等待及进程清理。
设置 / Settings
N/A:未修改设置项或设置页。
插件契约 / Plugin contract
N/A:未修改契约、Core pin、宿主方法或通知。
发行包与资源 / Bundle and resources
N/A:未新增或修改资源及构建步骤。发行目录运行时只读静态检查已通过。
无用代码与重构 / Dead code and refactoring
验证 / Verification
完整包与竞态验证在 b582e20 基线上完成;提交前已重放到最新 preview 7126dbe,并针对新依赖再次执行终端菜单用例。最终改动仅三份文件。
未能执行的检查和原因: Linux/Windows 原生运行及真实产品窗口未执行。按维护者明确要求跳过本 PR 和合入提交的 CI;提交和 squash 标题均保留 [skip ci],不把 CI 标记为通过。
提交前确认 / Final checks