Repository navigation
Relevance filter: Ember review follow-ups - #3
Merged
Merged
Conversation
…ting edits. Invalid bytes past the 8192-byte probe are binary, a leading BOM stays in the text, non-string answers fail open, and a quoted yes or no with a reason still counts. The playground snapshots classifier rates and cancels an in-flight run when the scenario or editor changes. Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Ember's post-merge review findings for the relevance filter (byte-safe decoding, run invalidation, cost snapshot, non-string fail-open, quoted-decision parser, BOM, effort-retry cache). Offline tests only; no publish. Head cdcfc63.