Skip to content

Follow-up to #5: UTF-8 exhaustive test + Cloudflare Pages config checks - #6

Merged
mikkel merged 3 commits into
mainfrom
cursor/js5-followup-cloudflare-utf8
Oct 14, 2026
Merged

mikkel merged 3 commits into
mainfrom
cursor/js5-followup-cloudflare-utf8

Conversation

@mikkel

@mikkel mikkel commented Oct 13, 2026

Copy link
Copy Markdown
Member

Addresses Ember's #5 points. UTF-8: exhaustive 1-3 byte tail test vs TextDecoder(fatal), 0 mismatches, code unchanged. Cloudflare: Pages settings verified read-only; adds docs/deploy.md, scripts/check-pages-settings.sh, CI repo-config test. npm test 184 pass / 0 fail / 4 live skipped.

Every 1-, 2- and 3-byte tail after 'a' (leads 80-FF, all continuations
plus non-continuation probes) is classified as text exactly when a fatal
streaming TextDecoder says a valid completion exists, and src/ and
landing/lib/ agree on all of them. No mismatches were found.

docs/deploy.md lists the expected Pages settings (production branch main,
auto production deploys on, output dir landing, no build command).
test/deploy_config.test.js asserts what the repo can prove, and
scripts/check-pages-settings.sh checks the dashboard read-only.
scripts/check-pages-settings.mjs replaces the shell script. It checks the
repository, production branch, automatic production deployments, preview
setting (all), build command, output and root directories, and the exact
domain set, and exits 1 on any drift. It reads a saved API response with
--from-file <path|->. test/check_pages_settings.test.js runs in npm test
with a passing fixture, a negative case per check, and a check that the
docs/deploy.md table equals EXPECTED.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Deploying patchling with  Cloudflare Pages  Cloudflare Pages

Latest commit: 44019d2
Status: ✅  Deploy successful!
Preview URL: https://87ca4987.patchling.pages.dev
Branch Preview URL: https://cursor-js5-followup-cloudfla.patchling.pages.dev

View logs

--from-file and stdin now go through the same envelope check as live mode:
anything but success:true with an object result (success:false, a missing
success or result, result:null, invalid JSON) exits 2 even when the
project data matches. pr_comments_enabled is checked and documented.
@mikkel
mikkel marked this pull request as ready for review October 14, 2026 03:51
@mikkel
mikkel merged commit 8d4c474 into main Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants