Skip to content

fix: pin managed hooks to installed CLI - #332

Merged
404-Page-Found merged 5 commits into
mainfrom
fix/308-pin-managed-hook-cli
Sep 24, 2026
Merged

404-Page-Found merged 5 commits into
mainfrom
fix/308-pin-managed-hook-cli

Conversation

@404-Page-Found

@404-Page-Found 404-Page-Found commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • make the captured cliPath authoritative in generated managed hooks
  • fall back to PATH-based commit-echo resolution only when the captured CLI is unavailable
  • add an end-to-end regression test covering PATH conflicts and the fallback

Fixes #308

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cd32e343-f741-4f16-9df7-659ae88866d7

📥 Commits

Reviewing files that changed from the base of the PR and between 65718e4 and edeabce.

📒 Files selected for processing (2)
  • src/git/hook.ts
  • tests/hook.test.mjs

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Shadow auto-approve: would not auto-approve because issues were found.

Re-trigger cubic

Comment thread tests/hook.test.mjs Outdated
@sonarqubecloud

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Bug fix making generated managed hooks prefer the captured CLI path over PATH-based commit-echo, adding an end-to-end regression test and an explicit fallback when that CLI is missing. Bounded behavior fix; no rollout, policy, schema, or contract expansion.

Re-trigger cubic

@404-Page-Found
404-Page-Found merged commit 60c952b into main Sep 24, 2026
7 checks passed
@404-Page-Found
404-Page-Found deleted the fix/308-pin-managed-hook-cli branch September 24, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Reliability] Managed hooks can execute a different commit-echo binary from the installed CLI

1 participant