Repository navigation
Add a Check & Build GitHub Actions workflow - #12
Merged
Merged
Conversation
✅ Deploy Preview for 4rays ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository has no continuous integration. Formatting regressions, type errors, and build failures are only caught locally, so a broken commit can land on
mainunnoticed. The groundwork already shipped in earlier migrations:package.jsondefines theformat:checkandcheckscripts, pinspackageManager: pnpm@11.22.0(read automatically bypnpm/action-setup), and setsengines.nodeto>=22.19.0, which Node 24 satisfies.Solution
Add
.github/workflows/test.yml, aTestworkflow with a singleCheck & Buildjob that runs on pull requests to and pushes tomain:actions/checkout@v7pnpm/action-setup@v6— reads the pinned pnpm version frompackage.jsonactions/setup-node@v7— Node 24 with pnpm cachepnpm install --frozen-lockfilepnpm format:check,pnpm check,pnpm build— each withif: ${{ !cancelled() }}, so one run reports every failure at once instead of stopping at the first.Scope and exclusions
main, or add new checks beyond the three commands already used to validate this repository.TODO.md: the correspondingArchitecture Synccheckbox is marked complete in the same commit.Validation
pnpm format:check— passed (covers the new YAML file)pnpm check— 0 errors, 0 warningspnpm build— passed,dist/index.htmlandsitemap-index.xmlgeneratedTestworkflow is expected to run green on this pull request itself.No pre-existing check failures; all three commands pass cleanly on this branch.
Built by:
piharness, modelzai/glm-5.3-flash