Repository navigation
Conversation
chrysh
marked this pull request as draft
November 2, 2026 21:49
chrysh
force-pushed
the
ocp-recovery-server
branch
from
November 3, 2026 09:53
cdbdded to
488a06d
Compare
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 3, 2026 16:32
86e91b8 to
232e160
Compare
chrysh
force-pushed
the
ocp-recovery-server
branch
from
November 3, 2026 19:30
488a06d to
9500192
Compare
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 3, 2026 19:30
232e160 to
fcce4df
Compare
chrysh
force-pushed
the
ocp-recovery-server
branch
from
November 9, 2026 10:37
9500192 to
6c5b0f7
Compare
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 9, 2026 10:37
fcce4df to
06f3b98
Compare
chrysh
force-pushed
the
ocp-recovery-server
branch
2 times, most recently
from
November 9, 2026 10:46
da4081c to
7243d9e
Compare
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 9, 2026 10:46
06f3b98 to
1208b0e
Compare
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 9, 2026 15:57
1208b0e to
696806f
Compare
RecoveryInterface and the dispatch answer one access at a time, and their in-crate tests check one access at a time. The new host test plays the sequence the BMC runs for a streaming boot, from PROT_CAP to the terminal RECOVERY_STATUS and DEVICE_STATUS values. The agent half goes through dispatch with command bytes and payloads, and the device half through the RecoveryInterface methods the policy side calls, such as take_activation. The i2c server-runtime is meant to call dispatch, and the policy loop to call the RecoveryInterface methods. The test decodes register bytes rather than calling the accessors, because the agent has only a response buffer. StagingSpy wraps RamStaging to record the size the device announced to the region, which RamStaging does not keep. The test reads the staged image back through ByteSource, so it reads the bytes the way the recovery flow will. Separate tests cover what the sequence cannot show in passing: - a failed stage names the image index it failed on - the device refuses an activate value of 0x1, and the field keeps ACTIVATE_IDLE, where a device that cleared the written bits would leave 0xe - the dispatch accepts an activation while the image is still short, so the recovery flow has to check that the image is complete - the forced recovery mode the agent writes to DEVICE_RESET stays set after take_reset_request, which clears only byte 0 - an agent that finds an activation pending from an earlier attempt writes the idle value first, so the next take_activation returns the activation for the image the agent announces now The transport is out of scope, so MAX_TRANSFER_BYTES is both the chunk size and the transport_max argument, and the test applies no SMBus payload limit. RecoveryCommand::scope() has no caller. HW_STATUS, INDIRECT_FIFO_CTRL, INDIRECT_FIFO_STATUS and INDIRECT_FIFO_DATA are Scope::RecoveryMode, and the dispatch serves them whether or not the device is in recovery mode. The test asserts what the dispatch does today. Signed-off-by: Christina Quast <christina.quast@9elements.com>
chrysh
force-pushed
the
ocp-agent-sequence-test
branch
from
November 13, 2026 17:00
696806f to
a10847c
Compare
chrysh
force-pushed
the
ocp-recovery-server
branch
from
November 13, 2026 17:01
7243d9e to
46611d2
Compare
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecoveryInterfaceand the dispatch answer one access at a time, and their in-crate tests check one access at a time. No test plays the sequence the BMC runs for a streaming boot.This PR adds a host test that plays that sequence, from PROT_CAP to the terminal RECOVERY_STATUS and DEVICE_STATUS values. The agent half goes through
dispatchwith command bytes and payloads, and the device half through theRecoveryInterfacemethods the policy side calls, such astake_activation. Separate tests cover what the sequence cannot show in passing, such as an activation pending from an earlier attempt. Mutatingclear_activationorrecord_drained_writemakes the test fail.RecoveryCommand::scope()has no caller, so the dispatch serves theScope::RecoveryModecommands whether or not the device is in recovery mode. The test asserts what the dispatch does today.Stack, review in order: