Repository navigation
Conversation
Contributor
Author
|
Apoloigies. I did not see #4531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed that
ACE.Databasewas still resolving MySqlConnector 2.4.0, even thoughACE.Serveralready references 2.6.2.This was generating an NU1902 warning for the known vulnerability tracked under GHSA-473q-m89c-ghf8.
Problem
ACE.DatabasereferencesPomelo.EntityFrameworkCore.MySql9.0.0 but doesn't explicitly specify a MySqlConnector version.When restored independently, the database project resolves MySqlConnector 2.4.0, while the server project resolves 2.6.2.
Fix
Added an explicit MySqlConnector 2.6.2 reference to
ACE.Database.csproj, matching the version already used byACE.Server.No application logic changes.
Validation
ACE.Databasenow resolves MySqlConnector 2.6.2.ACE.Serverusing .NET 10.ACE.Database.csproj.Impact
Keeps the MySqlConnector version consistent across the projects and prevents
ACE.Databasefrom independently restoring the vulnerable 2.4.0 version.Since
ACE.Serveralready references 2.6.2, this is primarily a dependency consistency and security cleanup.