Skip to content

Add PEtab SciML example notebook - #3208

Merged
BSnelling merged 5 commits into
mainfrom
bes/sciml_notebook
Jul 15, 2026
Merged

BSnelling merged 5 commits into
mainfrom
bes/sciml_notebook

Conversation

@BSnelling

Copy link
Copy Markdown
Collaborator

The notebook uses the Dandekar petab sciml benchmark. It demonstrates loading the problem, running simulations and implementing a basic training loop.

@codecov

codecov Bot commented Jul 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.83%. Comparing base (65a652a) to head (feb4740).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
- Coverage   78.46%   77.83%   -0.63%     
==========================================
  Files         317      317              
  Lines       20974    20974              
  Branches     1482     1482              
==========================================
- Hits        16458    16326     -132     
- Misses       4508     4640     +132     
  Partials        8        8              
Flag Coverage Δ
cpp 72.09% <ø> (ø)
cpp_python 36.67% <ø> (ø)
petab 47.15% <ø> (ø)
petab_sciml 16.21% <ø> (ø)
petab_sciml_benchmarks 14.76% <ø> (ø)
python 70.31% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSnelling
BSnelling force-pushed the bes/sciml_notebook branch from 54004fc to eba5f44 Compare July 14, 2026 12:37
@BSnelling
BSnelling marked this pull request as ready for review July 14, 2026 13:16
@BSnelling
BSnelling requested a review from a team as a code owner July 14, 2026 13:16

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @dweindl does this look good to you?

@dweindl

dweindl commented Jul 15, 2026

Copy link
Copy Markdown
Member

@dweindl does this look good to you?

The example itself looks good to me, thanks.
Is it meant to be executed on GitHub actions / Read The Docs?
If so, generally preferred, please clear the output. However, I assume that urlretrieve will often fail due to rate-limiting, and we'd have to obtain those files from some place other than raw.githubusercontent.com.
If not, please rerun with a fresh kernel for clean output (first code cell starting at [1], all cells executed in order).

@dweindl

dweindl commented Jul 15, 2026

Copy link
Copy Markdown
Member

and we'd have to obtain those files from some place other than raw.githubusercontent.com.

See PEtab-dev/libpetab-python#503 for an alternative

@socket-security

socket-security Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​petab-sciml@​0.0.198100100100100

View full report

@BSnelling

Copy link
Copy Markdown
Collaborator Author

Thanks @dweindl! I cleared the notebook outputs so it executes like the others do and updated the file fetch to use the CDN you recommended.

@dweindl dweindl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Looks good now.

@BSnelling
BSnelling enabled auto-merge July 15, 2026 09:50
@BSnelling
BSnelling added this pull request to the merge queue Jul 15, 2026
Merged via the queue into main with commit 8935e72 Jul 15, 2026
29 of 30 checks passed
@dweindl
dweindl deleted the bes/sciml_notebook branch September 30, 2026 19:11
@dweindl dweindl added PEtab PEtab-import related JAX Related to the JAX-backend. documentation labels Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation JAX Related to the JAX-backend. PEtab PEtab-import related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants