Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 331 331
Lines 23688 23689 +1
Branches 1674 1674
=======================================
+ Hits 19120 19121 +1
Misses 4562 4562
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fix-expdata-presim-reinit
branch
2 times, most recently
from
October 28, 2026 14:52
a7e5a6b to
e0642f7
Compare
dweindl
force-pushed
the
fix-expdata-presim-reinit
branch
from
November 14, 2026 19:03
e0642f7 to
ba366d9
Compare
`ExpData(Model)` translated the model's reinitialization setting only into `reinitialization_state_idxs_sim`, not into `reinitialization_state_idxs_presim`, although it applies to the start of both periods. Furthermore, `ConditionContext` applied these index lists only if the respective fixed parameters were provided in the `ExpData`. Without `fixed_parameters_presimulation`, presimulation uses the main fixed parameters, but no states were reinitialized at its start, unlike with `ExpData.reinitialize_fixed_parameter_initial_states`. Apply the index lists independently of whether fixed parameters are provided, for presimulation and, for consistency, the main simulation. Fixes AMICI-dev#3458. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
fix-expdata-presim-reinit
branch
from
November 16, 2026 09:58
ba366d9 to
5a98b02
Compare
dweindl
marked this pull request as ready for review
November 16, 2026 11:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model.set_reinitialize_fixed_parameter_initial_states(True)applies to the start of presimulation and of the main simulation, butExpData(model)only translated it intoreinitialization_state_idxs_sim, leavingreinitialization_state_idxs_presimempty. With pre-equilibration and presimulation, states were therefore not reinitialized at the start of presimulation.Furthermore,
ConditionContextappliedreinitialization_state_idxs_presimonly iffixed_parameters_presimulationwas set. Without it, presimulation uses the main fixed parameters, and states still weren't reinitialized at its start, whereasExpData.reinitialize_fixed_parameter_initial_states = Truedoes reinitialize them. The index lists are now applied independently of whether the respective fixed parameters are provided; for consistency, this also applies toreinitialization_state_idxs_simandfixed_parameters. Nothing changes forExpDataobjects with empty index lists (the default, except forExpData(model)with reinitialization enabled in the model).Behavior changes for users:
ExpData(model), and forExpDataobjects withreinitialization_state_idxs_presim/reinitialization_state_idxs_simset butfixed_parameters_presimulation/fixed_parametersempty (previously, these index lists were silently ignored).reinitialization_state_idxs_presimis set withoutfixed_parameters_presimulationand these states are reinitialized, as reinitialization at the start of presimulation is not yet supported for adjoints (Enable adjoint preequilibration for models with solver state reinitialization #1156). Previously, this ran without reinitialization.PEtab-based workflows are not affected (no presimulation, and fixed parameters are always set if there are any).
Fixes #3458.
Relates to #3453.
🤖 Generated with Claude Code