Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 80.71% 80.75% +0.03%
==========================================
Files 331 331
Lines 23688 23737 +49
Branches 1674 1674
==========================================
+ Hits 19120 19169 +49
Misses 4562 4562
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
petab_v1_placeholders
branch
from
November 15, 2026 11:40
3807cea to
1f9a4a4
Compare
dweindl
marked this pull request as ready for review
November 15, 2026 13:51
dweindl
marked this pull request as draft
November 15, 2026 18:15
dweindl
force-pushed
the
petab_v1_placeholders
branch
from
November 15, 2026 21:52
1f9a4a4 to
bdf55f9
Compare
`SbmlImporter` no longer treats symbols named `noiseParameter{n}` /
`observableParameter{n}` in observation model formulas as placeholder
parameters. Instead, placeholders are declared on the respective
`MeasurementChannel` via the new `noise_placeholders` and
`observable_placeholders` arguments. The PEtab v1 and v2 importers
declare them for JAX imports. This way, the core importer doesn't
depend on PEtab naming conventions, and the information which
placeholder belongs to which observable is kept.
Placeholders are currently only used by the JAX backend, which binds
their values by position:
* `sbml2jax` requires identifiers `noiseParameter{n}` /
`observableParameter{n}` with contiguous indices starting at 1
* `sbml2amici`, the PySB importer, and event-resolved measurement
channels raise `NotImplementedError` if placeholders are declared
* declaring a placeholder with the ID of a model entity is an error
Relates to AMICI-dev#3294.
Co-Authored-By: Claude <noreply@anthropic.com>
dweindl
force-pushed
the
petab_v1_placeholders
branch
from
November 16, 2026 12:05
bdf55f9 to
ad29a5e
Compare
dweindl
marked this pull request as ready for review
November 16, 2026 12:06
dweindl
marked this pull request as draft
November 16, 2026 12:06
dweindl
marked this pull request as ready for review
November 16, 2026 13:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SbmlImporterno longer treats symbols namednoiseParameter{n}/observableParameter{n}in observation model formulas as placeholder parameters. Instead, placeholders are declared on the respectiveMeasurementChannelvia the newnoise_placeholdersandobservable_placeholdersarguments. The PEtab v1 importer declares thenoiseParameter{n}_{observableId}placeholders it already rewrites for JAX, the PEtab v2 importer the explicitly declarednoisePlaceholders/observablePlaceholders. This way, the core importer doesn't depend on PEtab naming conventions.Declaring placeholders per measurement channel, rather than per import call, keeps the information which placeholder belongs to which observable. This is needed for supporting measurement-specific placeholders in the SUNDIALS backend later on.
Placeholder parameters are currently only used by the JAX backend, which binds their values by position. Therefore:
sbml2jaxrequires placeholder identifiers of the formnoiseParameter{n}/observableParameter{n}, with contiguous indices starting at 1sbml2amici, the PySB importer, and event-resolved measurement channels raiseNotImplementedErrorif placeholders are declaredPEtab-based imports are not affected, except for one corner case: if a PEtab v2 observable declares a placeholder that doesn't occur in its formula, simulating the JAX model previously failed with
ValueError: too many values to unpack. The importer now declares all placeholders of an observable, so that the values are bound by position.Only direct
sbml2jaxcalls that relied on the name-based detection need to declare the placeholders now (see changelog); this is not known to be used outside the PEtab importers.Relates to #3294.
🤖 Generated with Claude Code