Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
===========================================
- Coverage 80.71% 49.99% -30.73%
===========================================
Files 331 331
Lines 23688 23696 +8
Branches 1674 1674
===========================================
- Hits 19120 11847 -7273
- Misses 4562 11751 +7189
- Partials 6 98 +92
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Logging every sensitivity check attempt over the full suite showed that most of the retry machinery is no longer used: * All checks pass at the first tolerance (1x, DAEs 100x), except the adjoint check of 00373 (simulation failure at 1x). Replace the up to 6-step tolerance ladder by a single retry at 100x looser tolerances, for all models. * The fallback to looser quadrature tolerances never helped. Always use tight quadrature tolerances. * The loosened FSA/ASA agreement tolerance after a retry was never needed (max. required rtol 2e-11). Always use rtol 1e-6. * Don't check `sigmay` sensitivities in the forward check: without an observation model, `sigmay` is constant. This removes 41% of the checked entries for 01395, the slowest case. Also share the setup of the three sensitivity checks, clone the forward solver for the adjoint part of the consistency check, and remove dead code from `jax_sensitivity_check`. References AMICI-dev#3262. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
sbml_suite_harness
branch
from
November 16, 2026 12:01
feef6a8 to
87ef12c
Compare
dweindl
force-pushed
the
sbml_suite_harness
branch
from
November 17, 2026 10:20
87ef12c to
73a4e82
Compare
The bound override for case 01395 fixed the lower bound of all 15 Hill coefficients at their nominal value, so their sensitivities were never checked. Only `v1_h`, `v3_h`, and `v15_h` are 1 and lead to `0**(negative)` when decreased; the others are 2 or 4. Restrict the override to those three. References AMICI-dev#3262. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Slightly negative species values due to integration errors make the non-integer powers in the Hill terms NaN, so that the simulation fails at isolated parameter values. Sensitivity checks that evaluate more points, such as fiddy's per-direction noise-floor probes, hit them. In the exact solution, no state can become negative within the check bounds: initial values are non-negative, all outfluxes are proportional to the respective species, and the influxes are non-negative. References AMICI-dev#3262. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the SBML test suite sensitivity check harness.
Logging every sensitivity check attempt over the full suite (temporary instrumentation, CI runs 43764432333 and 43862917864) showed that most of the retry machinery is no longer used:
sigmaysensitivities, which are constant without an observation model. This removes 41% of the checked Jacobian entries for 01395, the slowest case (forward check 197 s -> 145 s). The remaining time is mostly fiddy's per-entry overhead, not integration.Also: share the setup of the three sensitivity checks, clone the forward solver for the adjoint part of the consistency check, and remove dead code from
jax_sensitivity_check(a tolerance case list not covering any checked case, an unreachable re-simulation).Before/after on the full suite: identical outcome for each of the 2872 sensitivity checks (2821 passed, 51 all-inconclusive adjoint event skips).
For 01395, the lower-bound override now only covers the Hill coefficients with nominal value 1 (
v1_h,v3_h,v15_h); the other 12 were never checked before and pass. Also, the states of 01395 are now kept non-negative: slightly negative species values due to integration errors made the non-integer Hill powers NaN, so that simulations failed at isolated parameter values (hit by more thorough finite-difference checks). The exact solution can't become negative within the check bounds._agrees_closelystays (it decides 01104, 01107, 01108). The01148tolerance special case inapply_settingsalso stays (the simulation check fails without it).References #3262.
🤖 Generated with Claude Code