Skip to content

CI: Remove obsolete sympy reinstallation steps - #3580

Open
dweindl wants to merge 1 commit into
AMICI-dev:mainfrom
dweindl:rm_sympy_reinstall
Open

dweindl wants to merge 1 commit into
AMICI-dev:mainfrom
dweindl:rm_sympy_reinstall

Conversation

@dweindl

@dweindl dweindl commented Nov 16, 2026

Copy link
Copy Markdown
Member

Several workflows (and the binder Dockerfile) re-installed sympy after pysb, because pysb used to pin sympy<1.12. We install pysb from its master branch, which allows sympy>=1.12 since pysb/pysb#611, so these steps are no-ops now. In test_petab_test_suite.yml, the unquoted pip install sympy>=1.12.1 was a shell redirect anyway (installing sympy and writing to a file =1.12.1).

Also drops the redundant pysb-dev re-installation in test_python_ver_matrix.yml, which installAmiciSource.sh already takes care of.

Note that the latest pysb release (1.17.0) still requires sympy<1.12, which makes the amici[pysb] extra unsatisfiable. That's not addressed here.

The binder Dockerfile change is not covered by CI.

🤖 Generated with Claude Code

These steps re-installed sympy after pysb, because pysb used to pin
`sympy<1.12`. We install pysb from its `master` branch, which allows
`sympy>=1.12` since pysb#611, so they are no-ops now. In
`test_petab_test_suite.yml`, the unquoted `sympy>=1.12.1` was a shell
redirect anyway.

Also drop the redundant `pysb-dev` re-installation in
`test_python_ver_matrix.yml`, already done by `installAmiciSource.sh`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dweindl dweindl added ci dependencies Pull requests that update a dependency file labels Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.71%. Comparing base (7fb8c57) to head (b65be57).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3580   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files         331      331           
  Lines       23688    23688           
  Branches     1674     1674           
=======================================
  Hits        19120    19120           
  Misses       4562     4562           
  Partials        6        6           
Flag Coverage Δ
cpp 75.31% <ø> (ø)
cpp_python 34.87% <ø> (ø)
petab 47.14% <ø> (ø)
petab_sciml 16.50% <ø> (ø)
petab_sciml_benchmarks 15.11% <ø> (ø)
python 72.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
dweindl marked this pull request as ready for review November 16, 2026 12:51
@dweindl
dweindl requested a review from a team as a code owner November 16, 2026 12:51
@dweindl dweindl self-assigned this Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant