Repository navigation
Conversation
These steps re-installed sympy after pysb, because pysb used to pin `sympy<1.12`. We install pysb from its `master` branch, which allows `sympy>=1.12` since pysb#611, so they are no-ops now. In `test_petab_test_suite.yml`, the unquoted `sympy>=1.12.1` was a shell redirect anyway. Also drop the redundant `pysb-dev` re-installation in `test_python_ver_matrix.yml`, already done by `installAmiciSource.sh`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 331 331
Lines 23688 23688
Branches 1674 1674
=======================================
Hits 19120 19120
Misses 4562 4562
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several workflows (and the binder Dockerfile) re-installed sympy after pysb, because pysb used to pin
sympy<1.12. We install pysb from itsmasterbranch, which allowssympy>=1.12since pysb/pysb#611, so these steps are no-ops now. Intest_petab_test_suite.yml, the unquotedpip install sympy>=1.12.1was a shell redirect anyway (installingsympyand writing to a file=1.12.1).Also drops the redundant
pysb-devre-installation intest_python_ver_matrix.yml, whichinstallAmiciSource.shalready takes care of.Note that the latest pysb release (1.17.0) still requires
sympy<1.12, which makes theamici[pysb]extra unsatisfiable. That's not addressed here.The binder Dockerfile change is not covered by CI.
🤖 Generated with Claude Code