Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
- Coverage 80.75% 80.71% -0.05%
==========================================
Files 331 331
Lines 23699 23707 +8
Branches 1674 1674
==========================================
- Hits 19139 19134 -5
- Misses 4554 4567 +13
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
pysb_v2_event_groundwork
branch
from
November 16, 2026 13:11
cac9ca9 to
4fbc7ab
Compare
* Event assignments to entities that are not (solver) state variables now raise a `ValueError` in `DEModel.generate_basic_variables`, i.e., before code generation, and in `Event.get_state_update`. Such assignments were silently dropped. * Add `Event.assignment_targets` and `Event.check_assignment_targets`. * `ode_model_from_pysb_importer` disables conservation laws with a warning for models with events, as the SBML importer does, instead of raising. Preparation for PEtab v2 condition changes in later periods for PySB models (AMICI-dev#3068). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
pysb_v2_event_groundwork
branch
from
November 17, 2026 06:59
4fbc7ab to
e8bce99
Compare
dweindl
marked this pull request as ready for review
November 17, 2026 08:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for PEtab v2 condition changes in later periods of PySB models (#3068):
ValueErrorinDEModel.generate_basic_variables, i.e., during model import before code generation. Previously, such assignments were silently dropped. AddsEvent.assignment_targetsandEvent.check_assignment_targets.pysb2amicinow disables conservation laws with a warning for models with events, assbml2amicidoes, instead of raisingNotImplementedError.First of three stacked PRs: this one → #3582 → #3583.
🤖 Generated with Claude Code