Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
- Coverage 80.75% 80.72% -0.04%
==========================================
Files 331 331
Lines 23699 23706 +7
Branches 1674 1674
==========================================
- Hits 19139 19137 -2
- Misses 4554 4563 +9
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Numeric `noiseParameters` were written directly to the `ExpData` noise scales, regardless of the noise formula. Now this is only done for observables whose noise formula is just `noiseParameter1_<observableId>`; otherwise, the override is applied via the parameter mapping. To cover this in CI, run the v1 test suite job against the current PEtab test suite (`main`) instead of the pinned pre-v2 commit: * Merge the v1/v2 `petab-test-suite` dependency groups. * Only run PEtab v1 SBML cases in `test_petab_suite.py` by default. * Keep testing PEtab v1 PySB import on the pinned pre-v2 test suite in a separate workflow step (`--legacy-pysb`, `petab-test-suite-v1-pysb`), until its removal (AMICI-dev#3541). * Unflatten the simulation table for case 0006 instead of comparing against hard-coded flattened observable IDs. * Drop the stale JAX xfail for the former case 0021. * Drop `experimentId` from JAX simulation tables, which the current `petabtests.evaluate_simulations` rejects alongside `simulationConditionId`. Relates to AMICI-dev#3560. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
petab_v1_numeric_noise_overrides
branch
from
November 17, 2026 07:01
01bd780 to
0c1cae7
Compare
dweindl
marked this pull request as ready for review
November 17, 2026 08:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes numeric
noiseParametersoverrides replacing the whole noise formula in the PEtab v1 SUNDIALS simulation path, analogous to #3584 for PEtab v2. Since #921,_get_measurements_and_sigmaswrote any numeric noise parameter into theExpDatanoise scales, regardless of the noise formula. Now this is done only for observables whose noise formula is justnoiseParameter1_<observableId>; otherwise, the numeric override is applied via the parameter mapping, which already handled it.To get test coverage from PEtab-dev/petab_test_suite#122 (new v1 case 0021, extended case 0006), the v1 test suite job now uses the current PEtab test suite instead of the pinned pre-v2 commit:
petab-test-suitedependency group (main).test_petab_suite.pynow only runs the PEtab v1 SBML cases by default; the v2 cases are run bytest_petab_v2_suite.py.petab-test-suite-v1-pysbgroup) and runs its PySB cases via the new--legacy-pysboption. These cases predate the new noise override tests, but the fixed code is the same for SBML and PySB models.experimentIdcolumn is dropped from the simulation table, since the currentpetabtests.evaluate_simulationsrejects tables with bothexperimentIdandsimulationConditionId.Fixes #3560 (together with #3584).
🤖 Generated with Claude Code