Skip to content

feat(wallet_screening): add provenance report_hash (#439) - #465

Merged
rosspeili merged 1 commit into
ARPAHLS:mainfrom
Hendobox:feat/issue-439-wallet-screening-slice4-provenance
Nov 2, 2026
Merged

rosspeili merged 1 commit into
ARPAHLS:mainfrom
Hendobox:feat/issue-439-wallet-screening-slice4-provenance

Conversation

@Hendobox

@Hendobox Hendobox commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Description

Slice 4 of #439: finish the wallet_screening v2 milestone with provenance.report_hash (canonical SHA-256 over the report body) and final docs/test polish. Stays on 2.1.0 per #461 guidance (no version drift).

Acceptance criteria → diff:

  • provenance.report_hash + generator via _attach_provenance / verify_report_hash → skills/finance/wallet_screening/skill.py; covered by execute success, offline-direct, Tornado vector, and test_verify_report_hash_detects_tamper
  • Catalog Data Schema + limitations + TBD skill-history → docs/skills/finance/wallet_screening.md
  • Directive: one-line audit note only (no schema lecture) → instructions.md
  • Card fixture includes provenance → tests/fixtures/card_ui_schema/finance__wallet_screening.json
  • CHANGELOG [Unreleased] note for slice 4

Closes the #439 milestone after merge (Ross on #461).

Type of Change

  • New Skill — new registry bundle under skills/
  • Skill Upgrade — changes to an existing skill under skills/
  • Bug Fix — incorrect runtime or framework behavior
  • Documentation — docs, README, CONTRIBUTING only
  • Framework Feature — skillware/core/ loader, env, adapters
  • CLI — skillware/cli.py, docs/usage/cli.md
  • Examples — examples/*.py, agent loops, examples/README.md
  • Packaging — PyPI wheel, pyproject.toml, MANIFEST.in
  • RFC / meta — templates, labels, CI, or large design doc

Checklist (all PRs)

  • Linked GitHub issue (Fixes #… or Refs #…)
  • Scope matches the issue — no unrelated refactors
  • Contribution complies with Legal notice and code ownership (original work, MIT license grant, no malicious logic)
  • python -m black --check ., flake8, and ruff check . pass locally (or CI-equivalent subset)
  • pytest skills/ and pytest tests/ pass locally when relevant
  • CHANGELOG.md updated under [Unreleased] when user-visible behavior changes
  • examples/README.md updated if this PR adds, renames, or removes a runnable script
  • Ran pytest tests/test_registry_docs.py when skills, examples index, or agent-loops matrix changed
  • Ran pytest tests/test_skill_docs.py when catalog Usage Examples or provider snippets changed

New or updated skill

Skip unless this PR adds or changes files under skills/.

Bundle and metadata

  • Skill at skills/<category>/<skill_name>/ (from templates/python_skill/ or equivalent)
  • manifest.yaml: name (full ID), version, description, parameters, constitution, real issuer
  • Optional: short_description, issuer.github, issuer.org, requirements, env_vars

Effect, Directive, Assurance

  • Deterministic skill.py (Effect; no ad-hoc LLM-generated execution paths)
  • instructions.md (Directive) explains when and how to use the skill
  • card.json (Presentation) issuer matches manifest when present
  • test_skill.py (Assurance) covers execution and schema expectations
  • SkillLoader.load_skill("<category>/<skill_name>") succeeds (or deps documented)

Documentation and catalog

  • docs/skills/<category>/<skill_name>.md, category hub row, row in docs/skills/README.md, and docs/sitemap.md
  • Usage Examples for Gemini, Claude, OpenAI, DeepSeek, Ollama per skill usage template

Constitution and safety (skills only)

Read-only screening. Provenance hash is integrity metadata only — no signing or broadcasting. Hosts should halt on DENY and require a person on REVIEW. Not legal advice.

Related Issues

Fixes #439

Emit a canonical SHA-256 provenance digest for audit integrity and finish slice-4 docs/test polish on 2.1.0.

@rosspeili rosspeili left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Hendobox. This completes all the remaining of #439 cleanly.
Merging as is and will backfill the tbd commit sha in doc history.

@rosspeili
rosspeili merged commit d58132f into ARPAHLS:main Nov 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Skill Upgrade]: finance/wallet_screening v2.0

2 participants