Repository navigation
chore(types): Phase 5 of #415, enable strict mypy checks - #471
Merged
rosspeili merged 2 commits intoNov 11, 2026
Merged
Conversation
13 tasks
rosspeili
approved these changes
Nov 11, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me @UroojFatima-052. Merging as is! Thanks a lot <3 This completes #415 cleanly. Well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #415
Phase 5: enables
check_untyped_defs = trueanddisallow_incomplete_defs = trueunder[tool.mypy]. The overrides block was already removed in Phase 4 (#470), somypy skillwarenow runs with zero overrides.Changes
Turning on
disallow_incomplete_defssurfaced 42no-untyped-deferrors, all partially annotated signatures. Annotation only, no logic changes:consoleparameters (37):Console, orOptional[Console] = Nonewhere it defaults toNoneinput_fnparameters (10):Optional[Callable[[str], str]]**kwargsincmd_evm_dispatch,cmd_mail,cmd_addressbook_dispatch:**kwargs: Any_print_menu(menu):List[Tuple[str, str, str]];cmd_interactive(parser):Optional[argparse.ArgumentParser]evm_config.get_web3:-> Any, sinceweb3is an optional dependency and may not be importabletypingimports; black reflowed a few long signaturescheck_untyped_defsdid not surface any additional errors.Verification
mypy skillware: Success, no issues in 25 files, no overridesblack --check skillware/flake8 skillware: cleanpytest tests/test_cli.py tests/test_evm_config.py: 156 passed