Repository navigation
Keep the evaluators' recursive frames to the arithmetic - #1928
Merged
Rafael-SOWNet merged 1 commit intoOct 17, 2026
Merged
Conversation
The interval and decimal evaluators each recursed through one method holding every arm, so every level of a deep sum carried the temporaries and closures of all of them. Checking a partial-fraction split of sqrt(d+k*x)/(a+b*x+c*x^2)^3, about 230 levels deep, overflowed a 1 MB stack, and the macOS runner's test host crashed on master. The arithmetic arms stay in the recursive method; the rest move to a method that is not inlined. The three rows of APowerOfALinearOverAPowerOfAQuadraticIntegralTest now integrate on a 512 KB thread. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's C# Test has failed on macOS since 930c5ba: the test host crashes with a stack overflow in
APowerOfALinearOverAPowerOfAQuadraticIntegralTest. Windows and Ubuntu are cancelled by fail-fast.The crash is in
IntervalEvaluation.Evaluate(and, once that is fixed,PreciseEvaluation.EvaluateNode), checking a partial-fraction split about 230 levels deep. Each evaluator recursed through one method that holds every arm, so each level's frame carried the temporaries and closures of all of them. Earlier masters were near the limit too: 67d8e8d overflows the same row on a 512 KB thread.Here the arithmetic arms stay in the recursive method, and the rest move to a method that is not inlined. No answer changes.
Each row integrated on a thread of a fixed size:
The suite passes locally: 15,531 passed, 0 failed (net10.0).
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura