Repository navigation
Run the test suite on Python 2.7 and 3.8 in GitHub Actions - #5
Draft
icanhasmath wants to merge 1 commit into
Draft
icanhasmath wants to merge 1 commit into
icanhasmath wants to merge 1 commit into
Conversation
The fork's only CI config was .travis.yml, which no longer runs, so pull requests reported no checks and security releases rested on local runs. Python 2.7 runs in the python:2.7 image because setup-python no longer provides it. tox.ini's addopts asks for pytest-cov, so the job clears it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's only CI config is
.travis.yml, which no longer runs, so pull requests show no checks. The 4.5.post1 security release (#4) was verified only by local Python 2.7 runs.This adds
.github/workflows/tests.yml. It runspytest testson every pull request and on pushes toversion-4.5.x:python:2.7container, with pytest 4.6.11, mock 3.0.5 and pyasn1 0.4.8.setup-pythonno longer provides 2.7.python:3.8container.tox.ini's[pytest] addoptsasks for pytest-cov, so the job passes-o addopts=..travis.ymlis left in place. Removing it is a separate change.Local run of the same commands in docker, on this branch: 92 passed on 2.7, 92 passed on 3.8. The doctests aren't run: 5 of them fail the same way on upstream 4.5, because their expected output is Python 3
b''.Tracking: Linear PROD-2446.