Repository navigation
Fix the profiles crash, the subcommand usage line and a strict startup check - #105
Merged
Merged
Conversation
…p check Three things found while auditing main for the 0.26 release. `fxcss profiles` printed its listing and then died with "too many values to unpack" whenever a profile held a theme installed from a repository: the hint about --check went into the closing notes as a bare string, and the notes are (mark, text) pairs. On Python 3.9 to 3.13 every subcommand called itself `fxcss <command> [options] new` in its usage and error lines, because argparse built the name from the hand-written usage of the top parser. The subparsers are now named explicitly. The Windows startup smoke test required exactly two Firefox launches. The session allows itself three there, and a run that needed the third recovered correctly and still failed the check. The test now accepts any count the session allows, and both read that count from one place. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Three fixes found while auditing
mainfor the 0.26 release. Each has a test that fails without it.fxcss profilescrashed after a repository install. The listing printed, then the command died withValueError: too many values to unpackwhenever a profile held a theme installed from GitHub, Codeberg or GitLab. The--checkhint was added to the closing notes as a bare string where the notes are(mark, text)pairs. 0.25.0 exits 0 here.fxcss <command> [options] newon Python 3.9 to 3.13. argparse derived each subparser's name from the top parser's hand-written usage line. The subparsers are now named explicitly. 0.25.0, and Python 3.14 and later, already printedfxcss new.mainthat needed the third recovered correctly and still failed. The test now accepts any count up to what the session allows, and both read it fromcore.startup_attempts().How it was tested
fxcss profilesagainst a scratch profile root holding a GitHub-installed theme: exits 0 and prints the--checkhint.fxcss newwith no argument on Python 3.12:fxcss new: error: ….python -m tests.smoke_startupagainst Firefox 158 on macOS passes. Windows runs only in CI.🤖 Generated with Claude Code