Repository navigation
Give the dialog capture test's Node helper room to start on a slow runner - #108
Merged
Merged
Conversation
…nner The Windows unit tests failed on main after #106 with a timeout in test_draw_failure_releases_snapshot_and_dismisses_prompt. The test runs a short script under Node and allowed it ten seconds. The script itself takes milliseconds; the time is Node starting, and this test is the first in the job to start it. That first start takes a little over two seconds on the Windows runner normally. On that run every later start was ten times slower than usual as well, and the first one passed the limit. The same tree had passed the same job on the pull request minutes earlier. The limit is now 120 seconds: still an end to a real hang, no longer a measure of the runner. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
CI on
mainafter #106 failed in Unit tests (Windows, py3.12): 863 of 864 tests passed, andtest_dialog_capture.DialogSnapshotTests.test_draw_failure_releases_snapshot_and_dismisses_prompterrored withsubprocess.TimeoutExpiredafter 10 seconds.Why
The test runs a short script under Node with a 10-second limit. The script takes milliseconds; the time is Node starting, and this is the first test in the job to start it.
So the runner was roughly ten times slower than usual for that job, and the cold start crossed the limit. Nothing in #106 touches this test or
core.DIALOG_VIEW, and the identical tree passed the same job on the pull request minutes earlier.The fix
The limit is 120 seconds. It still ends a real hang; it no longer measures the runner.
How it was tested
python -m unittest tests.test_dialog_capturepasses locally (0.3 s). The failure itself needs a slow Windows runner, so it was not reproduced.🤖 Generated with Claude Code