Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Problem
GetSuperclass previously used Python
__mro__[1]to determine the superclass.For classes defined with
JavaClassDef(..., jvm_super=Parent),__mro__[1]is stillobject, resulting in the wrong JNI superclass.Python MRO reflects implementation-language inheritance, not the emulated Java hierarchy. This project models Java inheritance via
jvm_super.This caused RegisterNatives and other JNI calls to resolve methods against
objectinstead of the actual Java superclass, leading to the failures described in #83.Previously GetSuperclass(Dog) would return
object(via__mro__[1]); with this change it correctly returnsAnimal. Classes with nojvm_superreturn NULL, matching JNI spec behavior.Change
Read
jvm_superinstead of__mro__. If unset (or not a class), return NULL.jvm_superis expected to reference a JavaClassDef-based class.Per the JNI spec, GetSuperclass returns NULL for
java.lang.Objectand interfaces — it is not an error condition.Test
tests/test_get_superclass.pyHappy to adjust if anything looks off!