Repository navigation
Conversation
- Pin every action to a full commit SHA (the tag is kept as a comment so Dependabot can still propose updates). - Give the build workflow a read-only token and drop the unused pull-requests permission from the formatter. - Pass workflow_dispatch inputs to scripts through environment variables and validate them first, instead of interpolating them into shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to the security review (see #116), covering the workflow files.
What changed
actions/checkout,actions/setup-java,actions/upload-artifactandstefanzweifel/git-auto-commit-actionwere referenced by tag, which the action's owner can move. Each now names a full commit SHA, with the tag kept as a trailing comment so Dependabot's existinggithub-actionsupdates still work.build-test.ymlnow declarescontents: read; it had nopermissionsblock, so it inherited the repository default.auto-format.ymldropspull-requests: write, which it never used.generate-spritesheet.ymlpasted${{ inputs.minecraft_version }},${{ inputs.render_size }},${{ inputs.pipeline }}and${{ github.ref_name }}straight intorun:scripts. They now arrive as environment variables, and a new first step rejects a version or render size that is not a plain version string or a number. Only people with write access can dispatch this workflow, so this was low risk, but it is the standard fix.Not changed
git push -ftoautomated/spritesheet-updatestays: that branch is owned by the workflow.Testing
Workflow changes cannot be run locally.
auto-formatruns on this PR.build-testonly triggers on.javaandpom.xmlchanges, so it will not run here;generate-spritesheetis manual. Worth dispatchinggenerate-spritesheetonce from this branch withspritesheet-onlybefore merging to confirm the pinned actions and input handling.