Repository navigation
Conversation
- Pin Marmalade to commit eef81aa0ff instead of master-SNAPSHOT, and let Renovate propose bumps alongside the asset-renderer pin. - List Maven Central ahead of JitPack so artifacts published on Central are never requested from JitPack first. - Raise transitive versions past published advisories: Jackson 2.18.11, httpclient5 5.6.3, httpcore5 and httpcore5-h2 5.4.3, log4j-api 2.25.5. - AssetDownloader: check the client JAR against Mojang's published SHA-1, reject versions that are not plain version strings, and refuse JAR entries that would extract outside the output directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to the security review (see #116), covering dependencies and the build tooling's downloads.
What changed
Marmalade is pinned. Both modules depended on
master-SNAPSHOT, which is whatever the branch holds on the day of the build. They now name commiteef81aa0ff, the commitmaster-SNAPSHOTresolved to during the review, so this changes no code today.renovate.jsongains a second manager so Renovate proposes Marmalade bumps the same way it does forasset-renderer.Maven Central is asked first. Maven queries repositories in declaration order and appends its built-in Central entry last, so JitPack was being asked first for every artifact, including
org.slf4j, Gson and the plugins' dependencies. Central is now declared explicitly ahead of JitPack. JitPack is still used for thecom.github.*libraries that Central does not have.Transitive versions raised past published advisories (managed in the parent pom; none is a direct dependency):
AssetDownloaderLimits of this PR
generatorartifact resolveslog4j-apithrough its own dependency tree and still gets 2.25.3 unless the upstream library updates. The advisory there is moderate and concernsMapMessageJSON output, which this library does not use.Testing
AssetDownloaderTest(2 tests) for the checksum check.dependency:treeshows the raised versions; a sample of generator and tooling tests passes. The full suite was not run locally.